Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaaban board submission #15

Open
Tobby8629 opened this issue Jun 8, 2023 · 4 comments
Open

Kaaban board submission #15

Tobby8629 opened this issue Jun 8, 2023 · 4 comments

Comments

@Tobby8629
Copy link
Owner

Tobby8629 commented Jun 8, 2023

In this milestone

  • we successfully created the kaaban board for the project
  • activity were spliced to each person in a group of 4
  • total time deligated for the project us 59.5 hours

Here is an image of the kaaban board

kaaban
@Meltrust
Copy link

Meltrust commented Jun 8, 2023

Hi STUDENT_MENTION

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not have a screenshot of the kanban board.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@Meltrust
Copy link

Meltrust commented Jun 8, 2023

Hi team,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

  • All cards have been assigned✔️

You can do it

Required Changes ♻️

  • According to the project requirements:

image

At the time of this review, these are the pointings:

@uchexm 29
@Tobby8629 24
@Osoro254Alex 19

According to the requirement, the difference among members cannot be more than 5.

However, 29 - 19 = 10, and 10 > 5.
This means @Osoro254Alex does not have enough points when compared to the other team members.

Kindly, correct this issue so we can meet this particular requirement.

Tip: Just reassign tasks, or play with the numbers.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@uchexm
Copy link
Collaborator

uchexm commented Jun 8, 2023

Thank you for the feedback we have updated the tasks accordingly.

@Meltrust
Copy link

Meltrust commented Jun 8, 2023

Hi team,

Wow, you did it 🎉

Brilliant

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To highlight

  • Pointings are now equal✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants