-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaaban board submission #15
Comments
Hi STUDENT_MENTION While you made a great effort in this project, unfortunately, I cannot proceed to review your code. Invalid Code Review RequestYou have submitted a project, that does not have a screenshot of the kanban board. Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏 Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. Invalid Code Review Request does not count into the code reviews limit. |
Hi team, Good job so far! To highlight:
Required Changes ♻️
At the time of this review, these are the pointings: @uchexm 29 According to the requirement, the difference among members cannot be more than 5. However, 29 - 19 = 10, and 10 > 5. Kindly, correct this issue so we can meet this particular requirement. Tip: Just reassign tasks, or play with the numbers. Optional suggestionsEvery comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
Thank you for the feedback we have updated the tasks accordingly. |
Hi team, Wow, you did it 🎉Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️Well done!Your project is complete! There is nothing else to say other than... it's time to merge it To highlight
Optional suggestionsEvery comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application. Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
In this milestone
Here is an image of the kaaban board
The text was updated successfully, but these errors were encountered: