Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions not included in sdist or wheel #7

Closed
layday opened this issue Mar 25, 2024 · 3 comments
Closed

Type definitions not included in sdist or wheel #7

layday opened this issue Mar 25, 2024 · 3 comments

Comments

@layday
Copy link

layday commented Mar 25, 2024

The following two files are missing from both the sdist and the wheel:

  • py.typed
  • can_ada.pyi
@TkTech
Copy link
Owner

TkTech commented Mar 29, 2024

Weirdly more difficult then it should be to fix this! Old-style manifests no longer seem to work, including it in the pyproject.toml caused a bug in some versions of pip, and in switching fully over to poetry to just use the pyproject.toml approach I ran into poetry bugs with pure extensions (no Python code).

I will most likely fully switch over to poetry + pyproject.toml and will fix the upstream bug in poetry.

@layday
Copy link
Author

layday commented Mar 29, 2024

You could try creating a stubs-only package if that's easier, renaming can_ada.pyi to can_ada-stubs/__init__.pyi - see https://peps.python.org/pep-0561/#stub-only-packages.

@TkTech TkTech closed this as completed Jun 21, 2024
@TkTech
Copy link
Owner

TkTech commented Jun 21, 2024

Resolved with 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants