From 7b723c1b492649120d971f279046cb1b2401bbf3 Mon Sep 17 00:00:00 2001 From: Tim Date: Wed, 6 Nov 2019 18:08:21 +0000 Subject: [PATCH] Use undefined instead of null as default value This fixes the type issues in #107. Also it makes more sense. I'm unsure about the `return undefined`. --- compile.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compile.js b/compile.js index e4e4007..c09ae25 100644 --- a/compile.js +++ b/compile.js @@ -101,7 +101,7 @@ function compileDest(ctx) { for (var i = 0; i < ctx._proto.fields.length; i++) { var field = ctx._proto.fields[i]; props[field.name + ': ' + JSON.stringify(ctx._defaults[field.name])] = true; - if (field.oneof) props[field.oneof + ': null'] = true; + if (field.oneof) props[field.oneof + ': undefined'] = true; } return '{' + Object.keys(props).join(', ') + '}'; } @@ -295,7 +295,7 @@ function getDefaultValue(field, value) { case 'string': return value || ''; case 'bool': return value === 'true'; case 'map': return {}; - default: return null; + default: return undefined; } }