Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a pull-request template #200

Closed
zepfred opened this issue Dec 18, 2023 · 0 comments · Fixed by #222
Closed

Create a pull-request template #200

zepfred opened this issue Dec 18, 2023 · 0 comments · Fixed by #222
Assignees
@zepfred
Labels
enhancement New feature or request

Comments

@zepfred
Copy link
Contributor

zepfred commented Dec 18, 2023

Discussed in TimefoldAI/timefold-solver#502

Originally posted by zepfred December 18, 2023
The goal is to create a standardized process for updating quickstart modules and a pull request (PR) template that includes checkbox fields that must be marked before submitting or merging a PR. Here are some examples:

  1. Does the proposed change, if needed, incorporate tests to prevent any regressions?
  2. Are the UI and JS files fully tested?
    • Did you check all UI buttons (E.g., solve and analyze buttons)?
    • Did you check the network calls?
    • Did you check the console messages?
  3. Do you have a green build?
@zepfred zepfred transferred this issue from TimefoldAI/timefold-solver Dec 18, 2023
@zepfred zepfred added the enhancement New feature or request label Dec 18, 2023
@zepfred zepfred self-assigned this Jan 3, 2024
@zepfred zepfred mentioned this issue Jan 3, 2024
Merged
9 tasks
@zepfred zepfred linked a pull request Jan 4, 2024 that will close this issue
feat: Adding a Pull Request Template #222
Merged
9 tasks
@triceo triceo closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepfred zepfred

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Adding a Pull Request Template zepfred/timefold-quickstarts
2 participants
@triceo @zepfred