Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for .keep (experimental mutate argument) #1

Open
nefosl opened this issue Mar 20, 2021 · 1 comment
Open

support for .keep (experimental mutate argument) #1

nefosl opened this issue Mar 20, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request low priority This issue is of low priority

Comments

@nefosl
Copy link

nefosl commented Mar 20, 2021

Thank you for this handy add-on and for pointing me to it in my Stack Overflow question a few months ago. The dplyover logo is great!
dplyover::across2 has worked well for me to do simple division over pairs of columns within dplyr::mutate.
I often use the .keep argument of dplyr::mutate (currently experimental); do you have any plans to make this work with dplyover?

@TimTeaFan
Copy link
Owner

Thanks for your feedback and the suggestion to support dplyr::mutate's .keep argument in across2. Without relying on {dplyr}'s internals, which I try to avoid, it might be a bit tricky. Even if I get it working, I think it won't be really performant. I will definitely look into it, but with a low priority, since a call to dplyr::select before or after dplyr::mutate will get you the same result, probably with a better performance. Or am I overlooking something? Are there cases where one call to dplyr::select won't solve the problem?

Btw, I didn't expect that someone is already using the package. Note that there are changes to the code which are not reflected in the version number, since I haven't released the package yet (this will change after the first release). Once the first version is released, I'd recommend to reinstall the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority This issue is of low priority
Projects
None yet
Development

No branches or pull requests

2 participants