diff --git a/src/borg/locking.py b/src/borg/locking.py index 4192f1f108..7ddb6df742 100644 --- a/src/borg/locking.py +++ b/src/borg/locking.py @@ -8,7 +8,7 @@ from .helpers import Error, ErrorWithTraceback from .logger import create_logger -ADD, REMOVE = 'add', 'remove' +ADD, REMOVE, REMOVE2 = 'add', 'remove', 'remove2' SHARED, EXCLUSIVE = 'shared', 'exclusive' logger = create_logger(__name__) @@ -313,6 +313,11 @@ def modify(self, key, op): if op == ADD: elements.add(self.id) elif op == REMOVE: + # note: we ignore it if the element is already not present anymore. + # this has been frequently seen in teardowns involving Repository.__del__ and Repository.__exit__. + elements.discard(self.id) + elif op == REMOVE2: + # needed for callers that do not want to ignore. elements.remove(self.id) else: raise ValueError('Unknown LockRoster op %r' % op) @@ -327,7 +332,7 @@ def migrate_lock(self, key, old_id, new_id): killing, self.kill_stale_locks = self.kill_stale_locks, False try: try: - self.modify(key, REMOVE) + self.modify(key, REMOVE2) except KeyError: # entry was not there, so no need to add a new one, but still update our id self.id = new_id diff --git a/src/borg/testsuite/locking.py b/src/borg/testsuite/locking.py index b8fb67797e..5c593bdda4 100644 --- a/src/borg/testsuite/locking.py +++ b/src/borg/testsuite/locking.py @@ -241,7 +241,7 @@ def test_kill_stale(self, lockpath, free_pid): assert roster.get(SHARED) == {our_id} assert roster.get(EXCLUSIVE) == set() assert roster.get(SHARED) == set() - with pytest.raises(KeyError): + with pytest.raises(NotLocked): dead_lock.release() with Lock(lockpath, id=cant_know_if_dead_id, exclusive=True):