Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge? #3

Closed
Hello1024 opened this issue Jul 28, 2022 · 4 comments
Closed

Merge? #3

Hello1024 opened this issue Jul 28, 2022 · 4 comments

Comments

@Hello1024
Copy link

Did you attempt to get this merged into Cura? Is there a PR?

@ThomasRahm
Copy link
Owner

There is a draft PR. I hope to get a bit more feedback (and i also need to update when I have time) before removing draft status. When/if I ask them to look at the over 4000 lines of code I want it to be as good as possible.

@chrisvanderpennen
Copy link

I'm still using this as my daily and tbh I think it's a shame it's getting slept on by not just Cura but the likes of prusaslicer/superslicer/etc. It's so much better than the stock Cura tree supports - which I'm pretty sure Bambu imported into their prusaslicer fork.

@DerGenaue
Copy link

I actually checked the source,
Bambu did indeed port the original Cura Tree Support.
There is definitely some attention around this Implementation (@ThomasRahm plz consider getting your PR out of the draft state);
I'm pretty sure Prusa is aware, too.

@DerGenaue
Copy link

tbh I think it's a shame it's getting slept on by not just Cura but the likes of prusaslicer/superslicer/etc.

@chrisvanderpennen
There you go; now it is public that the new "organic support" that'll be released with the next Prusa Slicer version (2.6) is based on this Tree Support Fork!
Cura also seems to have accelerated their efforts to merge this Fork, so exciting times ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants