Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input DEM vertical datum is wrong for all Autel and some Parrot and DJI aircraft #24

Closed
mkrupczak3 opened this issue Jun 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@mkrupczak3
Copy link
Member

mkrupczak3 commented Jun 8, 2023

The GPS standard uses the WGS84 reference ellipsoid as an idealized model of the earth's shape and size. This model is most commonly used for specifying horizontal location using lat/lon, but height above/below the ellipsoid is also commonly used as a vertical datum, such as with standard GPS

An alternative, commonly used vertical datum is EGM96, which is an Earth gravitational model which takes the rotation and gravity of the earth into consideration and uses the resultant expected sea level as the reference point for altitude.

Open Athena must be able to consume either vertical datum for its input drone images

According to the widely used EPSG identifier codes for projections:

EPSG:4326 is a commonly used geodetic coordinate system based on the WGS84 ellipsoid, and EPSG:4979 is a 3D version of EPSG:4326 that includes height information. For EGM96, the EPSG code is 5773.

@mkrupczak3 mkrupczak3 added bug Something isn't working enhancement New feature or request labels Jun 8, 2023
@mkrupczak3 mkrupczak3 changed the title Determine whether input DEM vertical datum is WGS84 or EGM96 Determine whether input DEM vertical datum is WGS84 or EGM96 and convert if necessary Jun 8, 2023
@mkrupczak3
Copy link
Member Author

mkrupczak3 commented Jun 14, 2023

The way that this version of OpenAthena handles altitude information is wrong for certain Autel, DJI, Parrot drones. This can result in target error of up to 30m in such cases.

This is a serious issue which must be addressed.

The altitude used for DJI and Skydio aircraft is orthometric above mean sea level (ASML) according to EGM96. The altitude of the input elevation model is also EGM96, therefore NATO MGRS and WGS84 geodetic output is correct (where the user must understand the vertical datum is EGM96, even if it's not labeled well currently).

The software currently does not convert from EGM96 orthometric to WGS84 ellipsoidal vertical datum, which negatively affects the accuracy of potential Cursor on Target output and CK-42 output, which both use an ellipsoidal vertical datum.

@mkrupczak3 mkrupczak3 self-assigned this Jun 14, 2023
@mkrupczak3 mkrupczak3 changed the title Determine whether input DEM vertical datum is WGS84 or EGM96 and convert if necessary Input DEM vertical datum is wrong for all Autel and some Parrot and DJI aircraft Jun 29, 2023
@mkrupczak3
Copy link
Member Author

mkrupczak3 commented Jun 29, 2023

See this git commit on the Android for the necessary fixes:

Theta-Limited/OpenAthenaAndroid@37a38b6

A library will need to be added for the Python version which may obtain the EGM96 geoid offset from the WGS84 reference ellipsoid at any given lat/lon

@mkrupczak3 mkrupczak3 added the good first issue Good for newcomers label Jul 4, 2023
@SlicedBacon
Copy link
Contributor

EPSG code 5773 only provides the EGM96 vertical datum. A compound CRS must be used to allow conversion. EPSG 9707 provides both WGS84 Lat/Long and EGM96 height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants