Improved compiler flags for the GNU toolchain

Author: Theodor-Lindberg

CMakeLists.txt

@@ -34,7 +34,7 @@ if(NOT ${BUILD_TESTS})
   get_filename_component(LINKER_SCRIPT linker/stm32f407vgt.ld ABSOLUTE)
 
   if(${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
-    set(W_FLAGS -Wall -Wextra -Wcast-align -Wunused -Woverloaded-virtual -Wpedantic -Wconversion -Wsign-conversion -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wnull-dereference -Wuseless-cast -Wold-style-cast -Wredundant-decls -Wundef -Wno-unused)
+    set(W_FLAGS -Wpedantic -Wall -Wextra -Wcast-align -Wunused -Wconversion -Wsign-conversion -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wnull-dereference -Wuseless-cast -Wold-style-cast -Wredundant-decls -Wundef -Wno-unused -Wsuggest-final-types -Wsuggest-override -Woverloaded-virtual)
   endif()
 
   # add libraries
@@ -46,7 +46,6 @@ else()
   project(${application_name} C CXX)
 
   if(${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
-    set(W_FLAGS -Wall -Wextra -Wcast-align -Wunused -Woverloaded-virtual -Wpedantic -Wconversion -Wsign-conversion -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wnull-dereference -Wuseless-cast)
     if(${ENABLE_COVERAGE})
       set(TEST_FLAGS --coverage)
       set(CMAKE_CXX_OUTPUT_EXTENSION_REPLACE 1)

cmake/GCC.cmake

@@ -5,10 +5,10 @@ set(CMAKE_CXX_COMPILER g++-7)
 set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
 
 # compiler: language specific flags
-set(CMAKE_C_FLAGS "--coverage -fno-builtin -Wall -fdata-sections -ffunction-sections -g -ggdb" CACHE INTERNAL "c compiler flags")
-set(CMAKE_C_FLAGS_DEBUG "" CACHE INTERNAL "c compiler flags: Debug")
-set(CMAKE_C_FLAGS_RELEASE "" CACHE INTERNAL "c compiler flags: Release")
+set(CMAKE_C_FLAGS "--coverage -fno-builtin -fdata-sections -ffunction-sections" CACHE INTERNAL "c compiler flags")
+set(CMAKE_C_FLAGS_DEBUG "-Og -g" CACHE INTERNAL "c compiler flags: Debug")
+set(CMAKE_C_FLAGS_RELEASE "-Os" CACHE INTERNAL "c compiler flags: Release")
 
-set(CMAKE_CXX_FLAGS "--coverage -fno-rtti -fno-exceptions -fno-builtin -Wall -fdata-sections -ffunction-sections -g -ggdb" CACHE INTERNAL "cxx compiler flags")
-set(CMAKE_CXX_FLAGS_DEBUG "" CACHE INTERNAL "cxx compiler flags: Debug")
-set(CMAKE_CXX_FLAGS_RELEASE "" CACHE INTERNAL "cxx compiler flags: Release")
+set(CMAKE_CXX_FLAGS "--coverage -fno-rtti -fno-exceptions -fno-builtin -fdata-sections -ffunction-sections" CACHE INTERNAL "cxx compiler flags")
+set(CMAKE_CXX_FLAGS_DEBUG "-Og -g" CACHE INTERNAL "cxx compiler flags: Debug")
+set(CMAKE_CXX_FLAGS_RELEASE "-Os" CACHE INTERNAL "cxx compiler flags: Release")

cmake/GNU-ARM-Toolchain.cmake

@@ -16,16 +16,16 @@ set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
 set(CORE_FLAGS "-mthumb -mcpu=cortex-m4 -mlittle-endian -mfpu=fpv4-sp-d16 -mfloat-abi=hard -mthumb-interwork --specs=nano.specs --specs=nosys.specs")
 
 # compiler: language specific flags
-set(CMAKE_C_FLAGS "${CORE_FLAGS} -fno-builtin -Wall -fdata-sections -ffunction-sections" CACHE INTERNAL "c compiler flags")
-set(CMAKE_C_FLAGS_DEBUG "-O0 -g3 -ggdb" CACHE INTERNAL "c compiler flags: Debug")
+set(CMAKE_C_FLAGS "${CORE_FLAGS} -fno-builtin -fdata-sections -ffunction-sections" CACHE INTERNAL "c compiler flags")
+set(CMAKE_C_FLAGS_DEBUG "-Og -g" CACHE INTERNAL "c compiler flags: Debug")
 set(CMAKE_C_FLAGS_RELEASE "-Os" CACHE INTERNAL "c compiler flags: Release")
 
-set(CMAKE_CXX_FLAGS "${CORE_FLAGS} -fno-rtti -fno-exceptions -fno-builtin -Wall -fdata-sections -ffunction-sections" CACHE INTERNAL "cxx compiler flags")
-set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g3 -ggdb" CACHE INTERNAL "cxx compiler flags: Debug")
+set(CMAKE_CXX_FLAGS "${CORE_FLAGS} -fno-rtti -fno-exceptions -fno-builtin -fdata-sections -ffunction-sections" CACHE INTERNAL "cxx compiler flags")
+set(CMAKE_CXX_FLAGS_DEBUG "-Og -g" CACHE INTERNAL "cxx compiler flags: Debug")
 set(CMAKE_CXX_FLAGS_RELEASE "-Os" CACHE INTERNAL "cxx compiler flags: Release")
 
 set(CMAKE_ASM_FLAGS "${CORE_FLAGS} -D__USES_CXX" CACHE INTERNAL "asm compiler flags")
-set(CMAKE_ASM_FLAGS_DEBUG "-O0 -g3 -ggdb" CACHE INTERNAL "asm compiler flags: Debug")
+set(CMAKE_ASM_FLAGS_DEBUG "-Og -g" CACHE INTERNAL "asm compiler flags: Debug")
 set(CMAKE_ASM_FLAGS_RELEASE "-Os" CACHE INTERNAL "asm compiler flags: Release")
 
 # search for programs in the build host directories