Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullscreen is not supported in android? #684

Closed
zhenliliu opened this issue Jul 8, 2017 · 7 comments
Closed

fullscreen is not supported in android? #684

zhenliliu opened this issue Jul 8, 2017 · 7 comments
Labels
stale Closed due to inactivity or lack or resources

Comments

@zhenliliu
Copy link

No description provided.

@rezaindrag
Copy link

I used react-native-orientation to solve this..

@dinatazy
Copy link

@rezaindrag can you provide us with more details?

@rezaindrag
Copy link

@dinatazy But the screen is not 100% full, I just change the orientation to LANDSCAPE

import Orientation from 'react-native-orientation';

inside render method:

// LANDSCAPE
if (this.state.orientation === 'LANDSCAPE') {
      <Video source={{ uri: VIDEO_SOURCE }}
            // set height/width 100%
            style={{ height: '100%`, width: '100%' }}
      />
}

// PORTRAIT
// normal height/width

I hope this will help you

@xyklex
Copy link

xyklex commented Feb 14, 2018

@rezaindrag thanks for you comment, I'm facing this issue but I can't solve it using you approach.

My use case, I have a screen with a news video half above a description of it half below, the user can play the video and if he wants it can tap the fullscreen icon, and continue watching the video fullscreen in the position it was.

I tried two things, one was the dimensions thing, when tapping the fullscreen icon setting a new style, height and width with the size of the screen, of course this doesn't works because I found that absolute positioning is relative to the parent, and the screen is not the parent of my video view.

the second try was to use a Modal and include the same Video component inside it, this almost works, the Modal was launched, the video insert it, a little minor issue with the statusbar, but the Video instead of continuing in the same position it was, it's starting again, like a new instance, when I'm actually using the same.

Do anyone have knowledge about why this is happening? I read the code of the library for android and found that it's using this library ScalableVideoView and that library is using MediaPlayer and TextureView, this last library allow the video stream to render in the same view without creating a new one.

I could help write a solution for this, but I'm just starting reading about android development and react native, so if someone could help would be appreciated. @dinatazy

@ashwinprasadme
Copy link

@xyklex any update from your side?

@dengue8830
Copy link

in my case, using

componentDidMount -> video.presentFullscreenPlayer()
or
fullscreen={true}

gives a random result, sometimes it hides the android bottom bar and sometimes don't (it makes a flash like hide->show android bottom bar)

@IbrahimSulai
Copy link
Contributor

Opened a PR (#1730) for full-screen support in Android Exoplayer.

@hueniverse hueniverse added the stale Closed due to inactivity or lack or resources label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to inactivity or lack or resources
Projects
None yet
Development

No branches or pull requests

8 participants