Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"controls" support for ios & "fullscreen" support for Android #369

Closed
louislai opened this issue Oct 30, 2016 · 7 comments
Closed

"controls" support for ios & "fullscreen" support for Android #369

louislai opened this issue Oct 30, 2016 · 7 comments
Labels
stale Closed due to inactivity or lack or resources

Comments

@louislai
Copy link

louislai commented Oct 30, 2016

Right now, react-native-video supports opening a fullscreen player on ios using presentFullScreenPlayer, but this option is missing in android. Similarly, I can toggle a native player controls using the controls prop, but this only works on Android.
Would be really nice if someone can implement native controls in iOS, and fullscreen player for Android inside the react-native-video package.

I tried to hack together a fullscreen player for android by creating a new Activity with a SurfaceView to display the video output. To stop the video from reloading I store the MediaPlayer object as a singleton https://github.com/louislai/react-native-video/blob/master/android/src/main/java/com/brentvatne/react/FullScreenVideoActivity.java
However, I hope that someone can give a more general and proper solution.

@louislai
Copy link
Author

Added a $100 bounty for this, because I really need these features https://www.bountysource.com/issues/38797648-controls-support-for-ios-fullscreen-support-for-android

@facejiong
Copy link

https://github.com/yamill/react-native-orientation may help you

@ShariqMush
Copy link

@louislai Please check, i have finally made fullscreen work on android, check your bounty page

@treemore
Copy link

controls={true} in android can work... i write the control code by myself.
and add controls={true} can not see the controlbar

@mrarronz
Copy link

mrarronz commented Mar 8, 2018

Guys check out my example code:

https://github.com/mrarronz/react-native-blog-examples/tree/master/Chapter7-VideoPlayer/VideoExample

I believe this is what you want although it comes a little late, I see this issue just now, in issue #534 , I also posted my solution.

@ghost
Copy link

ghost commented Jan 21, 2019

Is this bounty still up for taking?

@IbrahimSulai
Copy link
Contributor

Opened a PR (#1730) for full-screen support in Android Exoplayer.

@hueniverse hueniverse added the stale Closed due to inactivity or lack or resources label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to inactivity or lack or resources
Projects
None yet
Development

No branches or pull requests

7 participants