Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile for tvOS due to picture-in-picture regression #1517

Closed
FullstackJack opened this issue Mar 12, 2019 · 1 comment
Closed

Comments

@FullstackJack
Copy link
Contributor

Current behavior

When you pull the latest release and try to build for tvOS, the build fails due to this library including an unsupported API for picture-in-picture on tvOS. Fails at AVPictureInPictureControllerDelegate in RCTVideo.h, but it's just the tip of the iceberg.

Reproduction steps

  1. Initialize the project with react-native init MyVideoApp && cd MyVideoApp && npm install
  2. npm install react-native-video && react-native link react-native-video
  3. Open the XCode project and add react-native-video to the Link Binaries for MyVideoApp-tvOS
  4. Select the build Scheme for tvOS with a tvOS simulator.
  5. See the build fail at AVPictureInPictureControllerDelegate in RCTVideo.h.

Expected behavior

The build should not include unsupported APIs (AVPictureInPictureControllerDelegate) in the tvOS build.

Platform

Which player are you experiencing the problem on:

  • tvOS
@FullstackJack
Copy link
Contributor Author

Caused by #1325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants