Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to exclude fragment route changes #92

Closed
mobeigi opened this issue Oct 1, 2024 · 1 comment
Closed

Ability to exclude fragment route changes #92

mobeigi opened this issue Oct 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mobeigi
Copy link
Contributor

mobeigi commented Oct 1, 2024

Hi all,

I am wondering if we could add the ability to exclude fragment route changes.

For example, if we are navigating to example.com/page#fragment I would like to avoid showing the progress bar.

The use case is I use fragments on my website exclusively to jump around the already fully loaded current page so there is no need to show the top loader in these cases as it is distracting.

The change seems simple enough, add a configuration option to enable fragments and then do a check for fragment when redirecting to url.

I am happy to contribute a PR for it if maintainers are happy with idea.

@TheSGJ TheSGJ added the enhancement New feature or request label Oct 1, 2024
@mobeigi
Copy link
Contributor Author

mobeigi commented Oct 3, 2024

Hey @TheSGJ , I put up a PR for your review, thanks 🙇

@TheSGJ TheSGJ closed this as completed in b1f63cb Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants