Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize execution services and execution result #352

Open
vinjana opened this issue Oct 9, 2020 · 1 comment
Open

Harmonize execution services and execution result #352

vinjana opened this issue Oct 9, 2020 · 1 comment
Milestone

Comments

@vinjana
Copy link
Contributor

vinjana commented Oct 9, 2020

The SSHExecutionService and LocalExecutionService use inconsistent behaviour with respect to

  • dealing with stdout and stderr (once its part of resultLines, once not)
  • dealing with wrapping commands in Bash

ExecutionResults should be able to handle stdout and stderr separately (but maybe optionally also intermingled, which is useful to keep the relative timing of output in both streams). Proper intermingled dealing, however, will still keep the lines from each separated!

Consider also whether asynchronous execution really makes sense, if much of the code is synchronous.

@vinjana vinjana added this to the 4.0 milestone Oct 9, 2020
@vinjana vinjana moved this to Backlog in RoddyCore May 29, 2024
@vinjana
Copy link
Contributor Author

vinjana commented Jun 20, 2024

We now only use the LocalExecutionService. Inconsistent behaviour, therefore, does not warrant the effort to harmonize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant