Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an existing templating mechanism for ConfigurationIssueLevel and rework the messages. #310

Open
dankwart-de opened this issue Nov 20, 2018 · 1 comment

Comments

@dankwart-de
Copy link
Contributor

vinjana 6 days ago Member

See comment in tests. Maximize information / character ratio.
@npeschke
npeschke 7 hours ago Member

I get this warning for the cvalues RODDY_JOBID, RODDY_JOBNAME, RODDY_QUEUE, scratchBaseDirectory and RODDY_SCRATCH which are not in direct control of the user. Therefore, it might be beneficial to either omit them from checking or rework the check to minimize users getting worried about the warning when running a job.

It might also be helpful to give a quick summary of the affected cvalues like

The values A, B, C in your configuration...

@vinjana
vinjana 3 hours ago Member

Yes, these values should not get warnings. The second option you propose I do not understand, but certainly users should not get worried unnecessarily.
@dankwart-de
dankwart-de just now Member

You are right and I'd like to change it. However, I'd like to postpone the changes and implement them together with a templating engine/mechanism (see below). I'll create an issue for it.

@vinjana
Copy link
Contributor

vinjana commented Nov 28, 2018

See #307 for the original discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants