Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation of speed boost? #331

Closed
arpowers opened this issue Nov 2, 2022 · 6 comments
Closed

Explanation of speed boost? #331

arpowers opened this issue Nov 2, 2022 · 6 comments

Comments

@arpowers
Copy link

arpowers commented Nov 2, 2022

sorry to leave an issue for this, but I couldn't figure out what exactly this library is doing that makes things faster and what the tradeoffs are...

Would be awesome to have a quick bulleted list about this since it seems like there are few things changed, a couple forked repos, etc...

thanks for the work!

@dtedesco1
Copy link

dtedesco1 commented Nov 2, 2022

I have the same questions. A bit hesitant to try this until there's more clarity.

@TheLastBen
Copy link
Owner

TheLastBen commented Nov 2, 2022

The speed increase + memory efficiency are both the result of xformers implementation, check out the original thread here : huggingface/diffusers#532

@MatthieuToulemont
Copy link

@TheLastBen if you want I wrote a blog post explaining how this works :)

@TheLastBen
Copy link
Owner

@TheLastBen if you want I wrote a blog post explaining how this works :)

Great ! thanks for sharing

@arpowers
Copy link
Author

arpowers commented Nov 2, 2022

thanks guys! can close this if you want, still not clear if there are tradeoffs since that's not specifically stated.

@TheLastBen
Copy link
Owner

I didn't notice any quality loss from my part

@arpowers arpowers closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants