-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt SPM #21
Comments
I was exploring the organization repositories, and it turns out this idea was implemented in other languages as well: TheAlgorithms/Java#474 |
I really want to take this work up. Any guidelines? |
Initially, we could create an initial manifest file ( A second step would be to validate that all files are compiling correctly, fixing the ones that aren't right. This might require some combined effort. The third step would be to allow the contributors to write and run unit tests over their implementations. This third step could be on a separate PR. |
@TiagoMaiaL These are brilliant ideas. If I might add, what do you think about making the contributions test-driven? We could split contributions up to two types: one that adds test cases for a particular algorithm and another that implements the algorithm after the test-cases are sufficiently exhaustive. |
@avismarahl I believe adding unit tests is a good idea, but enforcing them might go against the organization goals, which are to welcome everyone to contribute and learn. Not everyone knows about unit tests, TDD, or Swift. So I believe we could add the support for it, and, if the contributors want, they can cover their implementation with a test suite, or even cover an implementation that doesn't have a test suite. One thing I believe would be a good idea to enforce is that the contributor changes don't break any existing unit tests. |
Gotcha. Makes sense. Also, how active is this repo? I just managed to move the entire repo into a Swift package. Even was able to run a couple of test cases. How do we continue from here? |
@avismarahl You can submit a PR with the manifest, I can test and review it. As I'm not a maintainer, we'd need the review from a maintainer as well. |
Done. I also observed that the naming conventions etc. aren't standard. Probably will take this up soon as well. |
Hello, everyone.
I've started my studies on algorithms, and I found this project pretty interesting and with lots of potential. I've already opened my first PR, and, while doing it, I've noticed we can't open the whole repository on Xcode (12.5). In order to test the code I was writing, I needed to develop it in a separate project, so I could then migrate it to this repository. I believe we can solve this issue by turning this repository into a Swift package. This would have the following advantages:
What do you think about it?
The text was updated successfully, but these errors were encountered: