Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many abandoned PRs #928

Closed
Panquesito7 opened this issue Jun 29, 2020 · 12 comments
Closed

Many abandoned PRs #928

Panquesito7 opened this issue Jun 29, 2020 · 12 comments

Comments

@Panquesito7
Copy link
Member

There are about 10 pages of open PRs without any comments, reviews or labels.
Shall we review those PRs, close them, or something else that you propose?

@ayaankhan98
Copy link
Member

@Panquesito7 i was also thinking about this, some of the PR's are very old and no one is likely to response over them, i think PR's which are older than 2 Months should be closed. @kvedala what's your opinion on this ?

@kvedala
Copy link
Collaborator

kvedala commented Jun 29, 2020

Once in a while, I go to the old commits and have requested the authors for status.
I think every author should get a chance to revive their contribution and if they do not respond for a maximum of 2 weeks, the pull-request should be marked "abandoned" and closed.
Open for suggestions and to check how such issues are being addressed in the other repos of TheAlgorithms group. - @AnupKumarPanwar

@Panquesito7
Copy link
Member Author

pull-request should be marked "abandoned"

The Stale app can help with this. 🙂

@ayaankhan98
Copy link
Member

Once in a while, I go to the old commits and have requested the authors for status.
I think every author should get a chance to revive their contribution and if they do not respond for a maximum of 2 weeks, the pull-request should be marked "abandoned" and closed.
Open for suggestions and to check how such issues are being addressed in the other repos of TheAlgorithms group. - @AnupKumarPanwar

okay let's ping the authors of the old PR, see if they response then it's nice else we will mark them "abandoned"

@kvedala
Copy link
Collaborator

kvedala commented Jun 29, 2020

Once in a while, I go to the old commits and have requested the authors for status.
I think every author should get a chance to revive their contribution and if they do not respond for a maximum of 2 weeks, the pull-request should be marked "abandoned" and closed.
Open for suggestions and to check how such issues are being addressed in the other repos of TheAlgorithms group. - @AnupKumarPanwar

okay let's ping the authors of the old PR, see if they response then it's nice else we will mark them "abandoned"

If someone has already messaged, it is pointless to post yet another message in the PR.
Please check before posting. Thank you

@fhlasek
Copy link
Contributor

fhlasek commented Oct 11, 2020

Very much agree - even closed PRs are quite easy to re-open if the author comes back.

@ghost
Copy link

ghost commented Nov 10, 2020

Hello everyone,

I am not sure who the main author of this repository is, but I have a project of working on open source code and was wondering which of the issues here are still open. Most of them have comments that say people are working on them. I was wondering if there were a couple open issues I could help address? @Panquesito7

@kvedala
Copy link
Collaborator

kvedala commented Nov 26, 2020

Hello everyone,

I am not sure who the main author of this repository is, but I have a project of working on open source code and was wondering which of the issues here are still open. Most of them have comments that say people are working on them. I was wondering if there were a couple open issues I could help address? @Panquesito7

Unless an issue is closed, it is very likely that it is un-resolved and anybody can contribute per the repo guidelines. Feel free to pick any such open issue and contribute. Thank you.

@stale
Copy link

stale bot commented Feb 13, 2021

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Author has not responded to the comments for over 2 weeks label Feb 13, 2021
@stale
Copy link

stale bot commented Mar 20, 2021

Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

@stale stale bot closed this as completed Mar 20, 2021
@Panquesito7 Panquesito7 added dont-close This issue/pull request shouldn't be closed and removed stale Author has not responded to the comments for over 2 weeks labels Mar 21, 2021
@Panquesito7 Panquesito7 reopened this Feb 10, 2023
@sozelfist
Copy link
Contributor

There are many awaiting PRs that opened on this repo. Why do the maintainers not look at these PRs or give suggestions to make these PRs better and ready to merge? Instead of abandoning these PRs and taking a bot to automatically assign stale labels on these PRs, try to have a look at them to decide which PR should be reviewed or merged.

@realstealthninja realstealthninja removed the dont-close This issue/pull request shouldn't be closed label Oct 4, 2024
@realstealthninja
Copy link
Collaborator

closing this issue as stale bot was added and the issue is resolved. We just lack reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants