Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global strings should be added for all navigation commands #51

Open
tarun42 opened this issue Dec 18, 2020 · 7 comments
Open

Global strings should be added for all navigation commands #51

tarun42 opened this issue Dec 18, 2020 · 7 comments
Labels
good first issue Good for newcomers

Comments

@tarun42
Copy link
Contributor

tarun42 commented Dec 18, 2020

Summary

Currently, for all commands(left('L'), right('R'),etc) a local string is passed to sendMessage() function.So add strings for all commands in res/values/strings.xml file and remove local strings passed to function calls.

@tarun42 tarun42 added the good first issue Good for newcomers label Dec 18, 2020
@preranashelke
Copy link

I would like to do this please assign it to me

@avivijay19
Copy link
Member

okay,

How will achieve that?

What is your plan?

@avivijay19 avivijay19 pinned this issue Jan 25, 2021
@debz-g
Copy link
Contributor

debz-g commented Dec 8, 2021

I have solved this issue. Also I have solved another issues. The manual control section was not showing R under status when pressed, I fixed it too. Can you please assign me this issue so that I can make the pr ?

@avivijay19
Copy link
Member

Hi @debz-g,
Can please share the approach how did you solved it?

@debz-g
Copy link
Contributor

debz-g commented Dec 8, 2021

Screenshot (11)
I added strings for respective directions in strings.xml and then I used getString(R.id.name) to access string.

@debz-g
Copy link
Contributor

debz-g commented Dec 8, 2021

Shall I push this?

@avivijay19
Copy link
Member

yes,
Please create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants