Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [BIM Tiles] Error when removing streamed model from scene #346

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Rocha442
Copy link
Contributor

@Rocha442 Rocha442 commented Apr 3, 2024

Description

After streaming an IFC model into the scene, if we call remove(modelID) from the FragmentStreamLoader, an error will be thrown by the loader's GeometryCullerRenderer remove(modelID), because while the _geometry property has been cleared, the _foundGeometry property will still have some of the model's geometry. The error is thrown the next time the culler is updated.

Additional context

This PR is trying to fix [issue:#345]
There is probably a more thorough approach to fix this issue, but for my use case this worked as intended. I just wanted to at least give attention to this issue.


What is the purpose of this pull request?

  • Bug fix

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Rocha442 Rocha442 marked this pull request as ready for review April 3, 2024 12:21
@agviegas agviegas merged commit 81d5279 into ThatOpen:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants