Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IfcPropertiesProcessor.getProperties is broken #324

Closed
5 tasks done
K1vs opened this issue Mar 15, 2024 · 1 comment
Closed
5 tasks done

IfcPropertiesProcessor.getProperties is broken #324

K1vs opened this issue Mar 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@K1vs
Copy link

K1vs commented Mar 15, 2024

Describe the bug 📝

When i use IfcPropertiesProcessor.getProperties i get list with empty objects, instead of list of objects with properties.
I found root cause in getProperties implementation - missed await keywords;
image

Reproduction ▶️

https://github.com/ThatOpen/engine_components/blob/main/src/ifc/IfcPropertiesProcessor/index.ts

Steps to reproduce 🔢

  1. Prepare scene with IFC model.
  2. Create IfcPropertiesProcessor
  3. Use getProperties
  4. Expected - list of objects with properties. Actual - list of emty objects.

System Info 💻

System:
    OS: Windows 11 10.0.22631
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700K
    Memory: 14.25 GB / 31.79 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.5 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.5.1 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Edge: Chromium (122.0.2365.80)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    openbim-components: ^1.4.4 => 1.4.15

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@K1vs K1vs added the bug Something isn't working label Mar 15, 2024
@K1vs
Copy link
Author

K1vs commented Mar 15, 2024

Can be fixed by #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants