Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore enabled parameter to its initial meaning #34

Open
cvila84 opened this issue Jul 23, 2019 · 1 comment
Open

Restore enabled parameter to its initial meaning #34

cvila84 opened this issue Jul 23, 2019 · 1 comment

Comments

@cvila84
Copy link
Member

cvila84 commented Jul 23, 2019

today, enabled parameter is used by spray to manage the order of deployment of sub-charts (e.g. all sub-charts enabled are set to false, and the sub-chart to be deployed has its enabled parameter set to true, and so on, to deploy all the sub-charts one by one).

it brings confusion especially because we may want to use enabled in a provided values.yaml to indicate we would like to deploy only a part of the umbrella chart (which is better than always use the --target or --exclude flag)

@cvila84 cvila84 changed the title restore enabled parameter to its initial meaning Restore enabled parameter to its initial meaning Jul 23, 2019
@pamiel
Copy link
Contributor

pamiel commented Jul 25, 2019

we may want to use enabled in a provided values.yaml to indicate we would like to deploy only a part of the umbrella chart (which is better than always use the --target or --exclude flag)

I'm not sure this is "better" than using the --target or --exclude, because these flags are the "official"/"visible" way to specify charts to be deployed or not; while the usage of the enabled value is the "internal"/"hidden" solution to do that.
My feeling is that we should avoid making such internal cooking be made available to the outside world (i.e. as a public "api").

More that that, how to manage a call to Helm Spray with both the --exclude flag on a chart and the enabled value for the same chart being set to true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants