Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Cursor on Windows should be "\x1b[?25l" #2170

Closed
jonathanding opened this issue Mar 30, 2023 · 2 comments · Fixed by #2171
Closed

Hide Cursor on Windows should be "\x1b[?25l" #2170

jonathanding opened this issue Mar 30, 2023 · 2 comments · Fixed by #2171

Comments

@jonathanding
Copy link

It uses \x1b[?25h in start_application_mode() of WindowsDriver. This actually shows the cursor rather than hide it so there is always a cursor on Windows platform. It should be changed to \x1b[?25l as what it does on Linux etc.

textual/src/textual/drivers/windows_driver.py

Line 80 in 2cd8295

self.write("\x1b[?25h") # Hide cursor

@github-actions
Copy link

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@willmcgugan willmcgugan mentioned this issue Mar 30, 2023
Merged
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for hiding cursor on windows Textualize/textual
1 participant
@jonathanding