Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install_screen shouldn't add screen to the DOM #1775

Closed
willmcgugan opened this issue Feb 13, 2023 · 1 comment · Fixed by #1778
Closed

install_screen shouldn't add screen to the DOM #1775

willmcgugan opened this issue Feb 13, 2023 · 1 comment · Fixed by #1778
Assignees
@willmcgugan

Comments

@willmcgugan
Copy link
Collaborator

Calling install_screen should add the screen to _install_screens but it should not add it to the DOM.

Screens should only be added to the DOM explicitly with push_screen or switch_screen
@willmcgugan willmcgugan self-assigned this Feb 13, 2023
@willmcgugan willmcgugan mentioned this issue Feb 13, 2023
Merged
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmcgugan willmcgugan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implements screens view Textualize/textual
1 participant
@willmcgugan