Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit for testrunner4iFixPlus #31

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

initial commit for testrunner4iFixPlus #31

wants to merge 10 commits into from

Conversation

ChopinLi-cp
Copy link

initial draft pull request for testrunner4iFixPlus

august782
august782 reviewed Feb 19, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
august782
august782 reviewed Mar 18, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
august782
august782 reviewed Mar 18, 2022
View reviewed changes
testrunner-running/src/main/scala/edu/illinois/cs/statecapture/StateCapture.java Outdated

Set<String> allFieldName = new HashSet<String>();
Class[] loadedClasses = MainAgent.getInstrumentation().getAllLoadedClasses();
String rootFold = rootFile.substring(0, rootFile.lastIndexOf("/"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems awkward to have to construct this rootFold based off of rootFile. What is rootFile used for ultimately? If there is not that much use for needing a directory to write things in (i.e., just a few files are needed for input/output), could those just be passed in as file names directly?

@winglam winglam marked this pull request as ready for review August 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@august782 august782 august782 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChopinLi-cp @august782