Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory.GetFileSystemEntries is missing the SearchOption parameter #775

Closed
StarWars999123 opened this issue Dec 9, 2021 · 5 comments · Fixed by #878
Closed

Directory.GetFileSystemEntries is missing the SearchOption parameter #775

StarWars999123 opened this issue Dec 9, 2021 · 5 comments · Fixed by #878
Assignees
@rkm
Labels
area: core Issues that address the core abstractions & the wrappers flag: good-first-issue Issues that are good for first time contributors state: ready to pick Issues that are ready for being worked on state: released Issues that are released type: enhancement Issues that propose new functionality

Comments

@StarWars999123
Copy link

The windows method for Directory.GetFileSystemEntries supports a parameter SearchOption to return not only values of the top most entries, but also the possibility to search within all sub directories. However, the mock hereby has no option for it yet.

It would be great to use this method here. Is there a chance, that you add this functionality?

(Function gets used within a .Net Core ASP.NET MVC application)
@StarWars999123 StarWars999123 added state: needs discussion Issues that need further discussion type: bug Issues that describe misbehaving functionality labels Dec 9, 2021
@StarWars999123
Copy link
Author

I was able to circumvent the usage of this parameter by the help of the following method: https://stackoverflow.com/a/25923435/4169550

A quick fix would be great anyway.

@fgreinacher
Copy link
Contributor

Thanks for the issue! We're currently missing this overload in our API. We can tackle this together with #774.

@fgreinacher fgreinacher added area: core Issues that address the core abstractions & the wrappers state: ready to pick Issues that are ready for being worked on type: enhancement Issues that propose new functionality and removed state: needs discussion Issues that need further discussion type: bug Issues that describe misbehaving functionality labels Dec 9, 2021
@fgreinacher fgreinacher added the flag: good-first-issue Issues that are good for first time contributors label Feb 28, 2022
@rkm
Copy link
Collaborator

rkm commented Mar 22, 2022

I should be able to take a look at this over the weekend

@rkm rkm self-assigned this Mar 22, 2022
@rkm rkm mentioned this issue Aug 22, 2022
Merged
@mergify mergify bot closed this as completed in #878 Sep 10, 2022
@github-actions
Copy link

This is addressed in release v17.2.1.

@github-actions github-actions bot added the state: released Issues that are released label Sep 10, 2022
@github-actions
Copy link

This is addressed in release v17.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkm rkm

Labels
area: core Issues that address the core abstractions & the wrappers flag: good-first-issue Issues that are good for first time contributors state: ready to pick Issues that are ready for being worked on state: released Issues that are released type: enhancement Issues that propose new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add GetFileSystemEntries with SearchOption rkm/System.IO.Abstractions
3 participants
@fgreinacher @rkm @StarWars999123