This repository has been archived by the owner on Oct 24, 2021. It is now read-only.
fix: game-over with wrong parts pickup #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should update the tests. I think for the togeaggle swap test case I cut the log before the game ended so no changes needed there |
Hoishin
changed the title
Hoishin
commented
May 23, 2019
| @@ -71,8 +71,8 @@ describe('hearthstone-log-watcher', () => { | |||
|
|
|||
| gameState.should.deep.equal({ | |||
| players: [ | |||
| {id: 1, name: 'SpookyPatron#1959', status: '', turn: false, questCounter: 6, timeout: 75, cardCount: 16, secrets: [], position: 'bottom'}, | |||
| {id: 2, name: 'SnarkyPatron#1301', status: '', turn: true, questCounter: -1, timeout: 75, cardCount: 18, secrets: [], position: 'top'} | |||
| {id: 1, name: 'SpookyPatron#1959', status: 'WON', turn: false, questCounter: 6, timeout: 75, cardCount: 16, secrets: [], position: 'bottom'}, | |||
There was a problem hiding this comment.
These values should have had 'WON' or 'LOST' before, because the dummy logs continues until the game ends.
Hoishin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 76.01% 78.04% +2.03%
==========================================
Files 13 14 +1
Lines 271 287 +16
Branches 50 50
==========================================
+ Hits 206 224 +18
+ Misses 45 43 -2
Partials 20 20
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 2.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think game-over is currently working
edit:
more specifically, the player's
statevalue isn't set currentlycloses #38