Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for passing custom CSS to modify popup #176

Closed
wants to merge 2 commits into from
Closed

Allow for passing custom CSS to modify popup #176

wants to merge 2 commits into from

Conversation

TerminalFi
Copy link
Owner

Potentially solves #117 But maybe we don't store in view settings and we rather just pass in session to allow grabbing settings

@TerminalFi TerminalFi linked an issue Jul 4, 2024 that may be closed by this pull request
popup width #117
Open
@jfcherng jfcherng force-pushed the master branch 2 times, most recently from 10ee440 to 6c84c74 Compare July 4, 2024 09:07
@jfcherng
Copy link
Collaborator

jfcherng commented Jul 4, 2024 •
edited
Loading

Another way to do that is letting the user to create a CSS file and we load/pass it into the Jinja template.

Pros

  • Better editting UX. Syntax highlighting, formatting...

Cons

  • It's a little bit cumbersome to create a override CSS file, with a comparison to edit a settings file.

@jfcherng jfcherng added the enhancement New feature or request label Jul 4, 2024
@TerminalFi
Copy link
Owner Author

Yes, we could do that as well, I would think we need to make it very user friendly to know how to do that.

Do you have any opinions?

@jfcherng
Copy link
Collaborator

jfcherng commented Jul 6, 2024 •
edited
Loading

I think using files are better. We can create menu for editing them.

@jfcherng
Copy link
Collaborator

jfcherng commented Jul 7, 2024 •
edited
Loading

Another way to do that is letting the user to create a CSS file and we load/pass it into the Jinja template.

Done in #178

@jfcherng jfcherng mentioned this pull request Jul 7, 2024
Merged
@TerminalFi TerminalFi closed this Jul 7, 2024
@TerminalFi TerminalFi deleted the impl/customizeCompletionPopup branch July 8, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

popup width
2 participants
@TerminalFi @jfcherng