Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #160

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

Fix typos #160

wants to merge 2 commits into from

Conversation

kianmeng
Copy link

No description provided.

docs/changelog.rst Outdated Show resolved Hide resolved
Copy link
Owner

@Terbau Terbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, thanks for actually doing this. You truly are a madman if you read through all the code just to find typos. Even though I'd prefer if the PR was aimed at the dev branch (my mad for not setting it up properly yet), I'll still merge it when everything is good to go.

@kianmeng kianmeng requested a review from Terbau November 27, 2021 11:36
@kianmeng
Copy link
Author

@Terbau Any updates on this?

@Terbau
Copy link
Owner

Terbau commented Jan 29, 2022

I will merge it as soon as I'm ready to push a new update. I've been holding off merging it until then since the current master branch should be the exact same as the one that you get from pypi. I'm planning on restructuring the branches in the future to avoid this.

@kianmeng
Copy link
Author

Noted, and thanks for letting me know. Take your times, I'm just follow up on my pending PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants