added timeout in accept_friend #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed timeout default from 60 seconds to None to be backwards compatible with existing implementations of the method. Also, made timeout a parameter of Client.accept_friend. It is a parameter of Client.wait_for and asyncio.wait_for so it is a parameter that you should be able to set when calling Client.accept_friend. |
Not-Bay
added a commit
to Not-Bay/fortnitepy
that referenced
this pull request
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Client.accept_friend method calls the Client.wait_for method without any timeout parameter. As a result, when asyncio.wait_for is called in Client.wait_for,
timeout = Noneis passed which causes a block until the futurecheck=lambda f: f.id == user_idcompletes. This pull request just adds a 60 second timeout so that, in the event that the future never completes, accept_friend does not block.