Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete doesn't work in latest Safari version #165

Closed
leolorenzoluis opened this issue Nov 22, 2016 · 11 comments
Closed

Autocomplete doesn't work in latest Safari version #165

leolorenzoluis opened this issue Nov 22, 2016 · 11 comments
Milestone

Comments

@leolorenzoluis
Copy link

Do you want to request a feature or report a bug?

Bug

Bug Report

  1. Go to https://teradata.github.io/covalent/#/components/chips
  2. Start typing where it says autocomplete input is supported
  3. Autocomplete is not showing, it just adds chips

What is the expected behavior?

Show autocomplete

Which version of Angular and Material, and which browser and OS does this issue affect?

Whatever the demo uses, latest safari version and macOS

Did this work in previous versions of Angular / Material?
No idea.

@emoralesb05
Copy link
Contributor

emoralesb05 commented Nov 22, 2016

Which version specifically of safari does this happen? We dont seem to be able to replicate it.

@kyleledbetter
Copy link
Contributor

I'm seeing it in Safari 10.0, the autocomplete dropdown doesn't work:
image

Native HTML5 input list isn't supported by Safari... I'm debating what we want to invest since angular-material2 is building this angular/components#117

@leolorenzoluis
Copy link
Author

leolorenzoluis commented Nov 23, 2016

@emoralesb05 10.0.1

@kyleledbetter Do you mean, you're just going to wrap TeraData components [Autocomplete] with Material 2? I guess my question is, does TeraData uses Material 2 as much as possible and have custom components that are not yet available in Material 2?

@emoralesb05
Copy link
Contributor

emoralesb05 commented Nov 23, 2016

true, md-autocomplete is coming so its better to just replace ours with that one inside td-chips.

That way, it will follow the material spec correctly.

@kyleledbetter
Copy link
Contributor

@leolorenzoluis the goal of Covalent is to build on top of angular-material2 and add to it, but in a few cases like this we needed a component before they had it so if their version meets all needs we'll retire ours, or if we need extra features we'll wrap it as you suggest

@leolorenzoluis
Copy link
Author

@kyleledbetter That's awesome, I am in the stage of evaluating Teradata to be used as a UI component as Material 2 is lagging behind from 1. How is the support for UI components? Is this free or there will be enterprise grade support in the future?

@kyleledbetter
Copy link
Contributor

No plans for enterprise support or commericalism. This is a traditional open source developed and community supported project that's free and licensed under MIT like everything it's built on

@leolorenzoluis
Copy link
Author

@kyleledbetter Just curious, you have more domain knowledge than me, but given that Material 1 has at least complete and stable API/components. Why doesn't Teradata just scrap existing Material 1 and just come up of a simple API such as for Autocomplete?

@kyleledbetter
Copy link
Contributor

It's a conplete rewrite for angular2 and the google team that wrote angular-material1 is the same team writing angular-material2 so essentially they're doing what you suggest

@leolorenzoluis
Copy link
Author

Hmm, then given Teradata is just building on top of Material 2, why won't Teradata just branch off Material 2 rather than having a separate repo? More exposure for people who contribute in Material 2 it self and less hassle marketing this UI component? All they have to do is branch from it, and more over you get the benefit of likely merging whatever API design you use now that are currently not available in M2?

@kyleledbetter
Copy link
Contributor

Not sure what you mean by just branch off Material 2 rather than having a separate repo < we include angular-material2 as a dependency just like any other node repo, just as we include angular2 itself. We don't want to replace any of those things or be responsible for maintaining that part of the code base. We want to build on TOP of all their hard work and add all the things missing to make a full-featured application.

Let's keep this issue focused on Autocomplete in Safari and head to our Gitter chat if you'd like to have philosophical debates about our architecture decisions :) https://gitter.im/Teradata/covalent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants