Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thresholds in charts should be displayed as lines and not areas #243

Open
julienlim opened this issue Nov 8, 2017 · 4 comments
Open

Thresholds in charts should be displayed as lines and not areas #243

julienlim opened this issue Nov 8, 2017 · 4 comments

Comments

@julienlim
Copy link
Member

julienlim commented Nov 8, 2017

For any thresholds set in any of the dashboard panel -- displayed as charts -- static thresholds should be shown as a line instead of an area to reduce user confusion.

Currently, the orange area that is intended to warn user that the threshold has been breach is causing confusion, i.e. some users perceive it as a "Weird line in Memory Utilization chart when [memory utilization is] stressed." See https://bugzilla.redhat.com/show_bug.cgi?id=1507942 for further details.

Since we're using static thresholds vs. dynamic thresholds, it would be preferable to show a line for the threshold and indicate in a tooltip that the threshold was breached vs. using a "threshold area" which is more typical for dynamic thresholds.

1031_memory_charts 2

@cloudbehl @Tendrl/tendrl-qe @mcarrano

@cloudbehl
Copy link
Member

cloudbehl commented Jan 30, 2018

Since we're using static thresholds vs. dynamic thresholds, it would be preferable to show a line for the threshold and indicate in a tooltip that the threshold was breached vs. using a "threshold area" which is more typical for dynamic thresholds.

Which Color line we should show for a threshold breach? Are we planning to go with a yellow line?

@julienlim
Copy link
Member Author

@cloudbehl @mcarrano @Tendrl/tendrl-qe

How many threshold values are set, and what value are they set to?

Per Tendrl/ui#701, I recall we had specified there that "If the progress bar has reached to 80% and above [Warning level] it should be changed to yellow and if reaches to 90% or above [Major / Critical level] it should be changed to Red."

I would try and follow that same as the colors mentioned in Tendrl/ui#701 to be consistent.

@cloudbehl
Copy link
Member

@julienlim In grafana, we are only setting the bar yellow bar(warning sign) at 80% there is no Critical Level we are setting.

@julienlim
Copy link
Member Author

@cloudbehl Ack. So, what we will want to do is show a yellow line to indicate the 80% threshold and indicate in a tooltip that the 80% threshold was breached. Can you please update/fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants