Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen macro does not forward some args to the underlying rule #1

Closed
krakeusz opened this issue Jun 28, 2024 · 1 comment
Closed

Comments

@krakeusz
Copy link

Hey,

First of all, this project is a good piece of work! Running doxygen with rules_doxygen is much easier than telling Bazel to run the doxygen binary.

I currently struggle a bit with making the doxygen rules optional. I don't want documentation to be built when running eg. bazel build ....

Typically, you would do this by writing:

doxygen(
    name = "doxygen",
    tags = ["manual"],
    # ...
)

But doxygen macro does not forward the tags to _doxygen rule. Actually, I can't set target_compatible_with in the doxygen macro because of a similar problem.

Would you consider forwarding **kwargs from doxygen to _doxygen? Both tags and target_compatible_with would be understood by the _doxygen rule automatically. That could solve these 2 issues and potentially more.

@TendTo
Copy link
Owner

TendTo commented Jun 28, 2024

Absolutely! Thank you for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants