fix(proxy): protect the program when getElementById throws an exception error #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢贡献！ |
|
@yiludege 其实 getElementById的对象可以不是document <html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
<h1>custom elements演示</h1>
<example-component></example-component>
<script>
window.customElements.define(
"example-component",
class extends HTMLElement {
constructor() {
super();
const mountPoint = document.createElement("div");
this.attachShadow({ mode: "open" });
mountPoint.innerHTML = `<h3>hello custom elements|<a id="aa" href="">aa</a></h3>`;
this.shadowRoot?.appendChild(mountPoint);
}
}
);
document.querySelector('example-component').shadowRoot.getElementById('aa'); //<a id="aa" href="">aa</a>
</script>
</body>
</html>demo会正常打印出#aa dom |
代理的目的就是为了在子应用内部 iframe的document.getElementById转发到 document.querySelector('example-component').shadowRoot.getElementById |
@yiludege 感谢回答，目的确实是为了这样。是我表达错误了，我修改了下问题为： |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test通过详细描述
与#547想法一致，在子应用中
document.getElementById会被代理成querySelector，而querySelector并不支持特殊字符的传递，比如当使用document.getElementById('aa/1')，会报错正常情况下
document.getElementById应该支持特殊字符，并且找不到的时候返回null，并不期望会报错；因此需要对document.getElementById代理做兼容异常处理