New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复messagePlugin获取实例错误的问题 #3514

Open

maoyiluo wants to merge 1 commit into Tencent:develop from maoyiluo:develop

Collaborator

maoyiluo commented Feb 28, 2025

🤔 这个 PR 的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

在多次调用messagePlugin方法的场景下，它返回的promise中的实例总是指向最后一次调用的实例。

修复方式：

在message被添加的时候，生成一个随机的key
在plugin resolve的时候，根据生成的key获取对应的实例

📝 更新日志

fix: 修复连续调用messagePlugin时，返回的实例不正确的问题
本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
Changelog 已提供或无须提供


          fix: 修复messagePlugin获取实例错误的问题

dd95462

maoyiluo requested review from chaishi, uyarn, xiaosansiji, liweijie0812 and LoopZhou as code owners

February 28, 2025 08:34

pkg-pr-new bot commented Feb 28, 2025

Open in Stackblitz

npm i https://pkg.pr.new/tdesign-vue@3514

commit: dd95462

Contributor

github-actions bot commented Feb 28, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chaishi Awaiting requested review from chaishi chaishi is a code owner

uyarn Awaiting requested review from uyarn uyarn is a code owner

xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

liweijie0812 Awaiting requested review from liweijie0812 liweijie0812 is a code owner

LoopZhou Awaiting requested review from LoopZhou LoopZhou is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet