Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderTnodeJSX 渲染 props 和 slots 的优先级问题 #5098

Closed
zhangpaopao0609 opened this issue Feb 26, 2025 · 2 comments
Closed

renderTnodeJSX 渲染 props 和 slots 的优先级问题 #5098

zhangpaopao0609 opened this issue Feb 26, 2025 · 2 comments
Assignees
Labels
🏃 in progress someone is developing monorepo monorepo

Comments

@zhangpaopao0609
Copy link
Collaborator

zhangpaopao0609 commented Feb 26, 2025

问题: 当前的 renderTnodeJSX 渲染 props 和 slots 存在优先级问题

  1. slotFirst 默认为 {},将导致默认渲染的是 slot,即 slot 优先级更高
// packages/components/hooks/tnode.ts
export const useTNodeJSX = () => {
  const instance = getCurrentInstance();
  return function (name: string, options?: OptionsType) {

    const slotFirst = getSlotFirst(options);

    ....
    
    if ((isPropsEmpty || slotFirst) && (instance.slots[camelCase(name)] || instance.slots[kebabCase(name)])) {
      return handleSlots(instance, name, params);
    }

    return propsNode;
  };
};
  1. 部分能同时作为 props 和 slots 的参数存在默认值,例如 badge 的 count。如果按照 props 优先级更高的原则,用户填写 slots 就没有意义了
// packages/components/badge/props.ts

  /** 徽标右上角内容。可以是数字,也可以是文字。如:'new'/3/99+ */
  count: {
    type: [String, Number, Function] as PropType<TdBadgeProps['count']>,
    default: 0,
  },

解决方案

  1. 修改优先级为:用户填写的 props 值 > slot > 默认 props 值 fix(hooks): useTNodeJSX #5102
  2. 弃用 packages/components/utils/render-tnode.ts 中的 renderTNodeJSX,全量使用 packages/components/hooks/tnode.ts 中的 useTNodeJSX

关于如何判断用户是否传某个 props,可参考 https://github.com/Tencent/tdesign-vue-next/blob/develop/packages/components/hooks/useVModel.ts#L20

Copy link
Contributor

👋 @zhangpaopao0609,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@uyarn
Copy link
Collaborator

uyarn commented Mar 1, 2025

close as completed

@uyarn uyarn closed this as completed Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏃 in progress someone is developing monorepo monorepo
Projects
None yet
Development

No branches or pull requests

2 participants