Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

发现几个bug，dynamic_masking 意思是不是写反了，多了not #80

Open
boluoyu opened this issue Aug 10, 2023 · 0 comments
Open

发现几个bug，dynamic_masking 意思是不是写反了，多了not #80

boluoyu opened this issue Aug 10, 2023 · 0 comments

Comments

@boluoyu
Copy link

boluoyu commented Aug 10, 2023 •
edited
Loading

1、在utils 的 dataset.py 中，凡是有self.dynamic_masking的地方是不是写反了？，如：

 if not self.dynamic_masking:
            src, tgt = mask_seq(src, self.tokenizer, self.whole_word_masking)
        else:
            instance = ((src, pad_num), seg_pos)

而命令行写上 --dynamic_masking 就是dynamic_masking 是true ， not true 才mask_seq，所以是多了not 吧？

2、 在generate_seq2seq.py 中32行
tmp_emb = str2embedding[embedding_name](args, len(args.tokenizer.vocab))
这里args.tokenizer 应该是args.tgt_tokenizer吧
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boluoyu