-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Provide a way to build on Windows using Bazel #79
Comments
hi, i didnt know that bazel was available for windows too, but actually : https://docs.bazel.build/versions/master/windows.html i'm very happy with the bazel program : it is very powerful and simple to use, and after the compile it works easily however that probably requires some work to implement, but that would be a premiere in the go AI world as far as i know @wodesuck @fiskerhuang @funionguo know better (i am only a contributor) |
Is it theoretically feasible to build PhoenixGo using current Bazel workspace on Windows? Or they should be modified to support Windows? |
@guikarist i dont know :) but if possible, that would certainly be a great acocmplishment |
I have try, but: 1. failed to use http_archive with |
@wodesuck Thanks for response. I have encountered the first problem, too. On Windows, MSYS2 is used for Bazel, so the code to run patch binary should be stripped of |
yes, most likely some building settings need to be modified but it's totally worth doing it not only that would solve many issues, and most of all that would be a great achievement (using bazel is so easy on powerful, even a total beginner can do it, while visual studio is such a pain to use) |
@guikarist a translation of @wodesuck comment in english using google translate (surprisingly understandable lol) :
it may be help you figure things out |
Thanks. My colleague has done this before. But it is obviously not simple and can only support Tensorflow which is built by CMake. And Tensorflow doesn’t support CMake since 1.11. Now I have succeeded in building |
i hope too @guikarist can you compile using visual studio 2015 rather then ? it would be very great to have a version with :
|
@wonderingabout |
@guikarist pity or not, i would appreciate if you provide a new release the old one is so outdated and slow 😭 |
@wonderingabout No problem, my colleague will do this and I will send you one as soon as he finishes. |
Now Tensorflow C++ API on Windows can be built but the output files have The |
@guikarist great !! this is the biggest highlights needed for a new windows release : it would be very great to have a version with :
cuda 10.0 would support turing GPU (RTX cards), and will improve performance on Volta cards (tesla V100, titan V, etc...,), as well as improve performance on all cards cudnn 7.4.x is significantly faster than the old cudnn 7.1.x avx avx2 fma cpu instructions are still lacking atm, which makes the computation a lot slower @guikarist https://github.com/wonderingabout/PhoenixGo/tree/faqv2-bazel-master |
@guikarist on ubuntu bazel always downloads tensorflow 1.8 i assume PhoenixGo engine is not yet compatible with tensorflow 1.9+ (but try, maybe you can, however i would try with supported version (1.8) first :) ) |
@wonderingabout @wodesuck @wonderingabout |
@guikarist i'm sure this will be greatly helpful for @wodesuck who manages the code, i read the main general lines, big thanks for your contribution on tensorflow for windows ! 👍 building on bazel is the ultimate ideal distant goal the main priority atm is to get a new release for windows no matter how it is built (visual studio or bazel) if i can help in any way i'd be glad |
@wonderingabout My pleasure! We had been trying buiding with Bazel. What we did with CMake is something one year ago. So it may need time for my colleague to do this. |
no problem, take your time @guikarist hope it goes well for you 👍 |
@wonderingabout We have just encountered a problem on building Tensorflow with CUDA 10 using CMake. I have read serveral issues and tutorials and find that CUDA 10 is very likely not to work on building Tensorflow using CMake on Windows. Now only usable Tensorflow built with CUDA 10 on Windows is a pip package built by Bazel, which cannot be used for building PhoenixGo. |
oh i understand, thanks for the feedback 👍 @guikarist then i guess its natural to go with cuda 9.0 instead, with cudnn 7.4.2, and the support of all modern cpu instructions in home computers (avx, avx2, fma), thta the existing build doesnt support can you gather the data about the various issues you encountered and their fixes, it may be helpful for other people in the future thanks again ! i'd like if you build with cuda 9.0 and the other settings i mentionned, thanks again for your effort ! 💯 there is really a need to upgrade the existing build which is so slow (40% of the speed of the ubuntu version with same settings, purpose is 80-90% of the speed) |
@guikarist any update or news on the basic compilation for windows ? it would be really a very big help |
Sorry to have kept you waiting. My colleague hasn't worked out, and I will have a try soon. |
@guikarist no problem really, i'm glad you're here again today 👍 forget cuda 10.0 if its too hard, let's try a more simple thing first so to sum up we now want a more simplistic build that just supports :
so 2 builds :
most users are on windows, so it may seem minimal but i'm sure it will be a big big help !!! 💯 |
maybe this can be given another try some future time, but thanks for the effort anyways 👍 |
Now that there is a pre-built binary of PhoenixGo on Windows, it is very kind of you to provide a way to build PhoenixGo on Windows using Bazel.
The text was updated successfully, but these errors were encountered: