Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method to get the novum app domain #195

Open
finuka opened this issue Jan 27, 2025 · 2 comments
Open

New method to get the novum app domain #195

finuka opened this issue Jan 27, 2025 · 2 comments
Assignees

Comments

@finuka
Copy link
Contributor

finuka commented Jan 27, 2025

Message type: GET_APP_DOMAIN

Originator: Web

Min app version: 25.3 or 25.4

Description

In B2P, the OB needs a method to get in which domain we are so they can built novum deeplinks like the one used to install an esim, for example https://app.alditalk.de/esim/installation-process/?activationCode=X&server=Y&msisdn=Z&afterInstallEsimUrl=https://app.alditalk.de/_/account/core/webviews/v2.php/?id=b2p-alditalk-accountoverview.
So the method will return the novum domain to the webview (as per the previous example: app.alditalk.de)

This method is needed because the OB has a white label code fully agnostic about novum brands and environments.

Differences between iOS/Android (if any)

N/A

Payload definition

Request Payload
No payload is needed in the request

getAppDomain: ()

Response Payload
The app returns to the OB a string with the current domain

domain: string;

Examples:

{"type": "GET_APP_DOMAIN", "payload": {"domain": "cert2-whatsappsimde.novum.team"}}

Possible error cases

N/A

@atabel
Copy link
Contributor

atabel commented Jan 28, 2025

LGTM, but I have some questions: Why is this needed? aren't those webviews running in the same domain? in that case location.host should be enough for them to know the domain. If they run in a different domain, then this could be useful

@finuka
Copy link
Contributor Author

finuka commented Jan 29, 2025

LGTM, but I have some questions: Why is this needed? aren't those webviews running in the same domain? in that case location.host should be enough for them to know the domain. If they run in a different domain, then this could be useful

I'm afraid those webviews run in an OB domain. I tried first using location.host, which was the proof to see that they run in a different domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants