Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflit with the rust generic "<T>" #19

Open
kyrosle opened this issue Feb 14, 2023 · 5 comments
Open

conflit with the rust generic "<T>" #19

kyrosle opened this issue Feb 14, 2023 · 5 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kyrosle
Copy link

kyrosle commented Feb 14, 2023

the <></> completion will happen outside the html!
image

@ttax00
Copy link
Owner

ttax00 commented Feb 24, 2023

Thanks for reporting the issue!

After a few days of digging, it seems to me that there might not be a way to limit the autoClosingPairs to only the embedded language region. I'll see if filing a issue/feature request in vscode could help. But definitely open to suggestion!

Edit: Found a similar issue from vscode microsoft/vscode#133397

@kyrosle
Copy link
Author

kyrosle commented Feb 24, 2023

will this problem fixed in the next version, or the readme.md will add some relvant introduction?

@ttax00
Copy link
Owner

ttax00 commented Feb 25, 2023

will this problem fixed in the next version, or the readme.md will add some relvant introduction?

This issue sprung from how VSCode handles the autoClosingPairs config, and it doesn't seem to work well with a variety of embedded languages, and not just html !. I'm still looking for a better approach, but right now there isn't much I can do besides removes the auto complete for <></>. So I'll leave the issue open for now.

@ttax00 ttax00 self-assigned this Feb 26, 2023
@NekoiNemo
Copy link

Would it be possible to add an option for enabling/disabling of auto complete for <></>? I feel like it would be a better stopgap solution than disabling it outright or leaving the issue as is until the real solution is found

@ttax00
Copy link
Owner

ttax00 commented May 14, 2023

@NekoiNemo That is actually a good idea. However, I'm not sure if there's a way to dynamically enable/disable language-configuration.json properties however. I'll look into it, but I can't see of a way to implement it for now.

@ttax00 ttax00 added bug Something isn't working help wanted Extra attention is needed labels May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants