Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construction Filter no longer working #1700

Closed
bjubes opened this issue Dec 17, 2016 · 3 comments
Closed

Construction Filter no longer working #1700

bjubes opened this issue Dec 17, 2016 · 3 comments

Comments

@bjubes
Copy link
Collaborator

bjubes commented Dec 17, 2016

Expected behavior

typing into the filter in the construction menu should search for furniture that matches the string and remove others from the list.

Actual behavior

nothing happens. This feature was working at some point so if anyone has a guess of when it regressed or can find the commit/PR that broke it by bisecting please post it.

@koosemose
Copy link
Collaborator

Well, I can't say when it broke, but I can tell you that it was a relatively recent PR, checking on my local master, it still works on there, and it was last updated to #1659 ( 95b3a44 ). It's entirely too late in my day to want to do bisecting, but that should at least be a decent starting point of a good bisect.

@koosemose
Copy link
Collaborator

I suppose I shouldn't be surprised... it's the PR that was doing stuff in the area of the menus and such, #1640

@koosemose
Copy link
Collaborator

I've found the issue (the Filter function isn't being called at all when the input field changes), however I can't fix it at the moment due to issues with Unity 5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants