Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SoundCloud] Tracks like count extraction is broken #1017

Closed
AudricV opened this issue Jan 22, 2023 · 0 comments · Fixed by #1024
Closed

[SoundCloud] Tracks like count extraction is broken #1017

AudricV opened this issue Jan 22, 2023 · 0 comments · Fixed by #1024
Labels
bug Issue is related to a bug soundcloud service, https://soundcloud.com/

Comments

@AudricV
Copy link
Member

AudricV commented Jan 22, 2023

According to 306e31a, SoundCloud was using for the likes count property, the name favoritings_count, and before this name, likes_count.

SoundCloud is currently using likes_count to return the like count of a track.

I don't know since when this change has been made, because I didn't see a report about this bug until today (on the NewPipe subreddit, in a post comment) (edit: it wasn't about these likes, but instead about the likes of a SoundCloud account).

This is an easy fix, and like count tests of SoundcloudStreamExtractorTest should be updated to assert a minimum like count, like done in other services where it is applicable.

@AudricV AudricV added bug Issue is related to a bug soundcloud service, https://soundcloud.com/ labels Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug soundcloud service, https://soundcloud.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant