-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interaction needs one tap before beeing able to interact #9773
Comments
Does #9812 solve the issue? You can find an APK in the Checks tab as soon as the build finishes |
@SameenAhnaf @IronGibbet I created a small testing application that simulates NewPipe's fullscreen behavior. When tapping on the FAB at bottom right, does the system UI appear on the first tap or only on the second? If it does so only on the second tap, then your OSs probably wrongly implement |
@Stypox Clicking on message icon shows blue notification bar with soft buttons. Swiping up shows the same but notification bar is black. Screenrecorder-2023-02-14-16-05-36-913.mp4 |
Both bars pop up at the first tap and stay until tapped again. The swiping, mentioned by @SameenAhnaf, also works (notification bar swipe down). Tapping anything else does nothing. If this gets closed I cannot deselect the "Close with comment". |
If an issue author closes an issue himself, he can reopen it himself. |
Thank you for testing. Let's now try with this NewPipe apk, built from a commit I pushed in #9785: app-debug.zip |
Sorry busy day. |
This comment was marked as spam.
This comment was marked as spam.
Related: https://issuetracker.google.com/issues/217596810. And I found online some other reports of people saying MIUI implements fullscreen mode wrong. @IronGibbet @SameenAhnaf Your device should have a setting somewhere to enable Fullscreen Mode (e.g. check this guide). Is NewPipe enabled in that list, or is it disabled by default? In case it was disabled, does the issue still persist if you enable it? |
Also, could you test this APK? I tried to apply the workaround suggested there. |
@Stypox |
just checked on my MIUI 13 (redmit note 11) since i have the same issue. i have fullscreen mode activated for newpipe, but it still doesn't work. in the version before the newest, the fullscreen worked without issues and i only have this issue since the newest version of newpipe got released. so apprently something got changed that screwed up the fullscreen mode & the other things mentioned here. |
..any update on this issue? |
@Stypox would it be possible to add the handling of fullscreen form the 0.24.1 and previous versions as an option to toggle when the current (0.25+) handling doesn't work? |
@Stypox any news on this issue? it's really quiet here.. will this issue be fixed with the next update? |
Don't ping team members by name. The relevant people are notified automatically. |
could please someone update us on this? it's a really annoying issue and it would be great to get an update on this. if i would have known about this issue i wouldn't had updated and waited.. but i can't even load a backup of my subscriptions on an old version of newpipe anymore because this crashes the app (new update+old app version=crash), so downgrading is no option it seems. so i'm stuck with the new version and this annoying bug. it feels a bit like we are getting ignored and this feels bad. |
It's a FOSS project. People volunteer their free time for this. No one owes you an explanation because you feel bad, and repeated comments won't achieve anything except irritate aforesaid volunteers into spending less time on the project. In general, always keep a data backup of an app's previous version before updating, in case things go wrong, just like they did for you here. Because they will go wrong at some point, no matter what app/OS/device it is. |
i understand that of course, but it still feels bad if you update in good faith and then there is an error.. you ask for help, but then suddenly there is no answer anymore and nobody responds anymore. a simple "hey, we are aware of the issue and try to fix it in the next update" or similiar answer would be already enough. but just silence.. is feeling really bad. i also usually make a backup before i update, but this one time i thought that it would be safe to don't do it once before updating.. and right then it happens. |
The topmost comment is literally a link to an APK trying to fix the problem, so I'm not sure what you're talking about here. |
quote: "I tried both with and without Fullscreen Mode enabled. Unfortunately without success. The behavior stays the same." when i tried it, i had the same result. it didn't worked. and after that, there was no comment about this issue anymore by anyone. and the merging got / is also blocked. for a long time now. it feels like nobody cares anymore about this issue here because of this. i understand that this is an opensource project done by people in their freetime & that i don't have the right to get everything i want. but i waited for a while to see what happens and to give the people trying to fix the issue time. but nothing happend anymore, so i asked for an update on this issue. thats all. |
You're asking too frequently. Try once in 2 months. |
The update is: we have no idea why this issue arose and since we can't reproduce we are unable to solve it. |
Thanks for your reply. Thanks in advance and keep up the good work. |
We reverted the change that caused issues in 0.25.0, so in 0.25.1 this issue should not be present anymore, see #9812 |
Checklist
Affected version
0.25
Steps to reproduce the bug
Expected behavior
or
1.double tap (or more) to skip/rewind
Actual behavior
Screenshots/Screen recordings
No response
Logs
No response
Affected Android/Custom ROM version
Android 11
Affected device model
Xiaomi veux
Additional information
Will rollback to 0.24.1
The text was updated successfully, but these errors were encountered: