Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction needs one tap before beeing able to interact #9773

Closed
6 tasks done
IronGibbet opened this issue Feb 9, 2023 · 25 comments · Fixed by #9812
Closed
6 tasks done

Interaction needs one tap before beeing able to interact #9773

IronGibbet opened this issue Feb 9, 2023 · 25 comments · Fixed by #9812
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@IronGibbet
Copy link

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25

Steps to reproduce the bug

  1. tap and hold
  2. swipe right side up (expected behavior not happening)
  3. only nav bar and pulldown bar appear
  4. tap and hold again you can right/left side swipe up/down

Expected behavior

  1. Tap and hold
  2. swipe up/down to adjust brightness/volume
    or
    1.double tap (or more) to skip/rewind

Actual behavior

  1. tap and hold screen
  2. nav bar and pulldown bar pop up
  3. no interaction possible
  4. tap and hold to adjust brightness or volume
  5. 50:50 chance nav and pulldown bar vanish after time

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 11

Affected device model

Xiaomi veux

Additional information

Will rollback to 0.24.1

@IronGibbet IronGibbet added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 9, 2023
@SameenAhnaf SameenAhnaf added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) and removed needs triage Issue is not yet ready for PR authors to take up labels Feb 10, 2023
@Stypox Stypox added this to v0.25.1 Feb 11, 2023
@Stypox
Copy link
Member

Stypox commented Feb 14, 2023

Does #9812 solve the issue? You can find an APK in the Checks tab as soon as the build finishes

@Stypox
Copy link
Member

Stypox commented Feb 14, 2023

@SameenAhnaf @IronGibbet I created a small testing application that simulates NewPipe's fullscreen behavior. When tapping on the FAB at bottom right, does the system UI appear on the first tap or only on the second? If it does so only on the second tap, then your OSs probably wrongly implement BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE and treat touches as swipes. We should be able to fix it anyway by showing NewPipe's controls whenever system bars are swiped into view by the user.

app-debug.zip

@SameenAhnaf
Copy link
Collaborator

@Stypox Clicking on message icon shows blue notification bar with soft buttons. Swiping up shows the same but notification bar is black.

Screenrecorder-2023-02-14-16-05-36-913.mp4

@IronGibbet
Copy link
Author

@SameenAhnaf @IronGibbet I created a small testing application that simulates NewPipe's fullscreen behavior. When tapping on the FAB at bottom right, does the system UI appear on the first tap or only on the second? If it does so only on the second tap, then your OSs probably wrongly implement BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE and treat touches as swipes. We should be able to fix it anyway by showing NewPipe's controls whenever system bars are swiped into view by the user.

app-debug.zip

Both bars pop up at the first tap and stay until tapped again.

The swiping, mentioned by @SameenAhnaf, also works (notification bar swipe down).

Tapping anything else does nothing.

If this gets closed I cannot deselect the "Close with comment".
Please reopen this if it should get closed, thank you.

@SameenAhnaf
Copy link
Collaborator

If this gets closed I cannot deselect the "Close with comment".
Please reopen this if it should get closed, thank you.

If an issue author closes an issue himself, he can reopen it himself.

@Stypox
Copy link
Member

Stypox commented Feb 14, 2023

Thank you for testing. Let's now try with this NewPipe apk, built from a commit I pushed in #9785: app-debug.zip

@IronGibbet
Copy link
Author

Thank you for testing. Let's now try with this NewPipe apk, built from a commit I pushed in #9785: app-debug.zip

Sorry busy day.
Just tested it.
The behavior stays the same like the initial 0.25 release.
One tap (landscape) nav and notification bar pop up, 2nd tap + hold swipe or mutli tap brightness up/down | volume up/down | ff/fb.
The notification bar shows icons switching from light to dark depending on the video but
av and notification bar stay until I tap again.
FF/FB work fine in portrait.

@Maxwell12347842

This comment was marked as spam.

@Stypox Stypox moved this to Issues in v0.25.1 Feb 25, 2023
@Stypox Stypox added the device/software specific Issues that only happen on some devices or with some specific hardware/software label Feb 25, 2023
@Stypox
Copy link
Member

Stypox commented Feb 25, 2023

Related: https://issuetracker.google.com/issues/217596810. And I found online some other reports of people saying MIUI implements fullscreen mode wrong.

@IronGibbet @SameenAhnaf Your device should have a setting somewhere to enable Fullscreen Mode (e.g. check this guide). Is NewPipe enabled in that list, or is it disabled by default? In case it was disabled, does the issue still persist if you enable it?

@Stypox
Copy link
Member

Stypox commented Feb 25, 2023

Also, could you test this APK? I tried to apply the workaround suggested there.
app-debug.zip

@IronGibbet
Copy link
Author

@Stypox
Thanks for both debug apps.
I tried both with and without Fullscreen Mode enabled. Unfortunately without success. The behavior stays the same.

@Maxwell12347842
Copy link

just checked on my MIUI 13 (redmit note 11) since i have the same issue. i have fullscreen mode activated for newpipe, but it still doesn't work. in the version before the newest, the fullscreen worked without issues and i only have this issue since the newest version of newpipe got released. so apprently something got changed that screwed up the fullscreen mode & the other things mentioned here.

@Maxwell12347842
Copy link

..any update on this issue?

@IronGibbet
Copy link
Author

@Stypox would it be possible to add the handling of fullscreen form the 0.24.1 and previous versions as an option to toggle when the current (0.25+) handling doesn't work?
Or are there to many dependencies for playback etc.?

@Maxwell12347842
Copy link

@Stypox any news on this issue? it's really quiet here.. will this issue be fixed with the next update?

@opusforlife2
Copy link
Collaborator

Don't ping team members by name. The relevant people are notified automatically.

@Maxwell12347842
Copy link

Maxwell12347842 commented Mar 30, 2023

could please someone update us on this? it's a really annoying issue and it would be great to get an update on this. if i would have known about this issue i wouldn't had updated and waited.. but i can't even load a backup of my subscriptions on an old version of newpipe anymore because this crashes the app (new update+old app version=crash), so downgrading is no option it seems. so i'm stuck with the new version and this annoying bug.

it feels a bit like we are getting ignored and this feels bad.

@opusforlife2
Copy link
Collaborator

it feels a bit like we are getting ignored and this feels bad.

It's a FOSS project. People volunteer their free time for this. No one owes you an explanation because you feel bad, and repeated comments won't achieve anything except irritate aforesaid volunteers into spending less time on the project.


In general, always keep a data backup of an app's previous version before updating, in case things go wrong, just like they did for you here. Because they will go wrong at some point, no matter what app/OS/device it is.

@Maxwell12347842
Copy link

Maxwell12347842 commented Mar 31, 2023

i understand that of course, but it still feels bad if you update in good faith and then there is an error.. you ask for help, but then suddenly there is no answer anymore and nobody responds anymore. a simple "hey, we are aware of the issue and try to fix it in the next update" or similiar answer would be already enough. but just silence.. is feeling really bad.

i also usually make a backup before i update, but this one time i thought that it would be safe to don't do it once before updating.. and right then it happens.

@opusforlife2
Copy link
Collaborator

"hey, we are aware of the issue and try to fix it in the next update" or similiar answer would be already enough

The topmost comment is literally a link to an APK trying to fix the problem, so I'm not sure what you're talking about here.

@Maxwell12347842
Copy link

Maxwell12347842 commented Apr 1, 2023

quote: "I tried both with and without Fullscreen Mode enabled. Unfortunately without success. The behavior stays the same."

when i tried it, i had the same result. it didn't worked.

and after that, there was no comment about this issue anymore by anyone. and the merging got / is also blocked. for a long time now. it feels like nobody cares anymore about this issue here because of this.

i understand that this is an opensource project done by people in their freetime & that i don't have the right to get everything i want. but i waited for a while to see what happens and to give the people trying to fix the issue time. but nothing happend anymore, so i asked for an update on this issue. thats all.

@opusforlife2
Copy link
Collaborator

so i asked for an update on this issue. thats all.

You're asking too frequently. Try once in 2 months.

@AudricV AudricV removed this from v0.25.1 Apr 2, 2023
@Stypox
Copy link
Member

Stypox commented Apr 3, 2023

The update is: we have no idea why this issue arose and since we can't reproduce we are unable to solve it.

@IronGibbet
Copy link
Author

Thanks for your reply.
The test app you wrote only supported portrait mode, the unwanted behavior occurs in landscape. Would you be able to get logs or any kind ouf information out of it, if it supported landscape?
How much effort would the workaround I mentioned in my previous post take if the handling of the 0.24.1 and below was left in as an option (i.e. legacy or MIUI-mode)?

Thanks in advance and keep up the good work.
IG

@Stypox
Copy link
Member

Stypox commented Apr 3, 2023

We reverted the change that caused issues in 0.25.0, so in 0.25.1 this issue should not be present anymore, see #9812

@Stypox Stypox closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
5 participants