Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow outside audio while in-player mute is active #9537

Closed
6 tasks done
J-Stutzmann opened this issue Dec 12, 2022 · 1 comment · Fixed by #10275
Closed
6 tasks done

Allow outside audio while in-player mute is active #9537

J-Stutzmann opened this issue Dec 12, 2022 · 1 comment · Fixed by #10275
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Comments

@J-Stutzmann
Copy link
Contributor

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

The player should not take audio focus while the in-player mute button is active.

To do this, the player should:

  • Not Request audio focus on play, when player is muted
  • Abandon audio focus on mute, when player is playing
  • Request audio focus on unmute, when player is playing
  • Not attempt to Request or Abandon audio focus when already in said state

In short, the player should Request audio focus only when moving into the "Playing + Unmuted" state, and Abandon it when moving to any other state.

Why do you want this feature?

In order to play audio from other apps while NewPipe is muted.

Additional information

N/A

@J-Stutzmann J-Stutzmann added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Dec 12, 2022
@J-Stutzmann
Copy link
Contributor Author

J-Stutzmann commented Dec 12, 2022

In addition, anyone looking to implement this should be aware that Play and onPrepared have separate audio focus requests.

@SameenAhnaf SameenAhnaf added player Issues related to any player (main, popup and background) and removed needs triage Issue is not yet ready for PR authors to take up labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants