-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Q/Request] Audio handling #941
Comments
Still no answer from the developer 😒😒😒 |
Mp3 support requires ffmpeg to be embedded. I wrote in several other issues why this didn't happen yet and why this is not going to happen. Just search for mp3 support.
Opus support got already requested and is listrd as an issue as long as i remember. |
@theScrabi What about a project like https://github.com/Sciss/jump3r ? This would require m4a -> wav (lossless), wav -> mp3 provided by above, so this would not increase the size as much as a full instance of ffmpeg. |
https://github.com/nwaldispuehl/java-lame seems to be another option. |
There is an app called video transcoder I think we could create an intent interface to that app. This way ffmpeg is encapsulated in another app, and if someone wanted to have this functionallity he could just install this app like an addon. |
@theScrabi thanks! I've posted a comment on an issue already tracking intent creation for the video-transcoder app. A seamless integration with another app would indeed be welcome, and would reduce the maintainable surface area for Newpipe. |
@brarcher what do you say, would you like to cooperate with us on that thing? |
I like the idea, @theScrabi. We can discuss the details in brarcher/video-transcoder#42. |
Great :D. Once this is done we should put a link to your transcoder on our readme/website. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Opus is here. Tapping gives me Poweramp as option. Check if done. |
1 is intended, 2 is not NewPipe's bug and 3 will maybe be in the new downloader at some point |
There are some limitations or issues when it comes to how newpipe handles audio imo.
Downloading Audio
When opening downloaded audio through Newpipe v0.11.2:
It opens as a popup. This is an issue because:
Player controls do not appear in notifications like regular audio players
The music stops playing when changing app, depending on app chosen to play it with. Google Play Music in my example
It does not load 'real' audio players as a choice to open it with. In my example, I'd like to play the audio with GoneMad Music Player
It does not list the actual audio formats. M4A (MP4) and webm are containers, both can hold several different types of audio (and video) formats. Would be better to list container and format on stream(s) inside. Audio would end up being WebM (Vorbis), WebM (Opus), M4A (AAC) etc.
For video, maybe WebM (VP9, Opus), MP4 (AVC, AAC), for instance.
Opus and mp3 support
Opus
Even though not all Android versions do support Opus, there are downloadable apps that do. Like GoneMAD Media Player. GMPP adds Opus support for all Android versions it supports, so the hard limit for v5 lollipop is not really the case. Please make it possible to show Opus streams as options when:
A) Streaming
a) Only show on supported devices (>5.0.0)
b) Or add opus decoder to the app as fallback
B. When downloading, all android versions.
MP3
Patents have expired, implementing MP3 support should be straight forward.
The text was updated successfully, but these errors were encountered: