-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup Default Resolution Setting Ignored #843
Comments
This is the expected behavior. If you are on the latest release (v0.11), then you can long click the popup button to start the video as a queue, where the player will use the default resolution. You will need to close the existing popup first though, as further queuing on an existing player will use the selected quality on the player. |
Oh, good to know. I updated to 0.11 before filing the report to ensure it was still present, tbh. Still, that setting could probably use a footnote added to it to let the user know it only applies to queueing. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still an issue because the user has no way of knowing about this behavior. |
Sorry for the previous (now deleted) comment. I forgot the way the intended behavior was supposed to work. Still, since I'm here, is there any update on letting the user know this from within the app? Cuz judging by how someone else filed a duplicate report a few months ago, I'm clearly not the only one getting tripped up by it. Even just renaming the setting to "Default Enqueued Popup Resolution" would be a big improvement and make it less likely to trip people up, though a little question mark that can be tapped for more detailed information would be even better. |
@Yowlen This seems to have been automatically resolved by the unified player (@avently you marvellous angel) so can you test this apk and confirm? https://github.com/TeamNewPipe/NewPipe/files/5083926/app-debug.zip |
Yes, I can confirm that it's solved in that build. The new in-window player looks great too. Needs the top bar with the back button put back imo, since NewPipe has different behavior for it than it does for the Android system's back button when opening external links and depending on the situation, I often use both. It'd be a pain to have to have to close NewPipe, return to the home screen, and then re-open it from there as an alternative to that back button. |
Alright. Closing this as fixed by #2907. |
The back button is still there on all views except the Video Details page. There, instead, you have the ability to swipe down to minimize the player. |
When playing as a popup, the player defaults to whatever is selected in the video.
For example, playing the video from the above screenshot in a popup window would render it in 720p despite having 360p set in the Settings:
The text was updated successfully, but these errors were encountered: