Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr #7451 messes up landscape view #7913

Closed
zer0fl0w opened this issue Feb 20, 2022 · 2 comments
Closed

pr #7451 messes up landscape view #7913

zer0fl0w opened this issue Feb 20, 2022 · 2 comments
Labels
template missing The bug/feature template is missing (e.g. the used app does not support issue templates)

Comments

@zer0fl0w
Copy link

this pr #7451 alters the way fullscreen landscape view is shown for displays with punchhole camera. before the video truly played fullscreen also overlaying the camera area. it used far more screen in total then now with v22 where the whole camera bar is blacked out/not used. viewing area is decreased and unsymmetrical. i understand the idea behind it but it is a regression for devices without a notch.

issues is seen here and here

the red line marks the area which was used by versions before v22. it was tested with two different devices running latest stock software: huawei nova 5t and oneplus 8t.

@nospace-here
Copy link

Same on the Pixel 4a. The "fit" position also is pushes the video to the left side, making content on the rounded corners cut off. Previous newpipe version did it correctly.

@litetex litetex added the template missing The bug/feature template is missing (e.g. the used app does not support issue templates) label Feb 21, 2022
@litetex
Copy link
Member

litetex commented Feb 21, 2022

Closed in favor of #7915 (← has a template)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template missing The bug/feature template is missing (e.g. the used app does not support issue templates)
Projects
None yet
Development

No branches or pull requests

3 participants