'Download has started' toast notification sometimes appears when it shouldn't

[subraizada3]

Checklist

• I am using the latest version - x.xx.x
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

See the 9 second video below, look at toast notifications. Or the written version:

Open a video, click the download button which opens a download popup dialog box, and then press OK to start the download. At this point the popup closes, a toast notification saying 'Download has started' appears, and the download starts.

Click the download button again, which opens the download options popup. Click OK to start the download. At this point, it opens a second popup saying that either there is a download in progress with this filename, or that this video is already downloaded. This second popup asks whether you want to cancel the operation (in which case the download never starts), or overwrite the existing download / generate a unique filename. However, when you click OK in the first dialog, as it opens this second dialog it simultaneously creates the toast saying that 'Download has started' - when in fact a download has not started.

Actual behaviour

See above.

Expected behavior

This toast should only show if the user chooses to overwrite or generate a unique name in the second popup.

Screenshots/Screen recordings

video.mp4

Device info

• Android version/Custom ROM version: LineageOS 18.1
• Device model: Pixel 5

This functionality was added in feature request issue #5428 and implemented in PR #5519.