Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic pause when playing #3481

Closed
vavavoum44 opened this issue Apr 25, 2020 · 8 comments
Closed

Automatic pause when playing #3481

vavavoum44 opened this issue Apr 25, 2020 · 8 comments
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@vavavoum44
Copy link

Describe the feature you want

Is your feature request related to a problem? Please describe it

Good morning,
First of all thanks for tour work on NewPipe. The application is very good.
I just have a problem and don't know where to Ask my question (sorry for Bad english, i am french) because I sée no forum concerning the app.

My problem is the following:
When I listen to music with NewPipe, even if I put it in background, when I do it at the same Time I play poker with the winam... android application (it is also the same with any application that usually automatically put youtube in pause when there is an action on it), every time there is an action on the poker table (every 5 seconds :-)), the video is put in pause and I have to manualy put play even when I chose in NewPipe parameters the option "resume reading after interruption (ex: phone call").

I am pretty sure tour team thought about that an I missuse the app but how should I do?

Thanks you for tour work again
Regards,

Boris

Additional context

How will you/everyone benefit from this feature?

@vavavoum44 vavavoum44 added the feature request Issue is related to a feature in the app label Apr 25, 2020
@androidSwDev099
Copy link

androidSwDev099 commented Apr 26, 2020

If I have NewPipe playing in background player and

  1. I make a phone call, NewPipe stops during phone call and resumes at end of phone call.
  2. If I start another non-phone call app that starts producing audio, NewPipe will stop and won't automatically resume playing even if the non-phone call app stops producing audio or I quit that app.

So it seems that the "Resume playing" setting is only applies to resuming after interruptions caused by phone call apps and other audio producing apps like games, YouTube, audio/video players, news apps, etc. Maybe the setting name needs to be changed to "Resume playing after phone calls". I have another music player with this setting which only resumes after phone calls - just like NewPipe.

@Stypox Stypox added bug Issue is related to a bug player Issues related to any player (main, popup and background) and removed feature request Issue is related to a feature in the app labels Apr 27, 2020
@opusforlife2
Copy link
Collaborator

Now that every player spawns a notification, can the media session be made high priority to override or use volume ducking for interrupts?

@Stypox
Copy link
Member

Stypox commented Sep 2, 2020

I don't know if this is a good idea, since implementing this would create issues for apps where instead it is expected that newpipe does not restart as soon as it can.

@opusforlife2
Copy link
Collaborator

@Stypox For example?

@Stypox
Copy link
Member

Stypox commented Sep 3, 2020

For example starting another player (e.g. vlc) supposedly means the user is not interested in newpipe's one anymore, and also similar scenarios... I don't think there is a clear best option, certainly many times you'd want newpipe to restart after the interruption, but I'd prefer the current implementation as it is the least invasive

@opusforlife2
Copy link
Collaborator

But normally media apps handle these things fine. If your music player is playing, and you get a notification, the volume ducks for a moment. If you get a call, the player pauses, then resumes after it ends. If you start another media session like VLC, the player pauses and doesn't resume at all.

@Stypox
Copy link
Member

Stypox commented Sep 3, 2020

Oh ok then, we should go with what you said:

Now that every player spawns a notification, can the media session be made high priority to override or use volume ducking for interrupts?

@opusforlife2
Copy link
Collaborator

Same as #2681?

@Stypox Stypox closed this as completed Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

4 participants