Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.17.1 #2531

Closed
theScrabi opened this issue Aug 17, 2019 · 10 comments
Closed

release v0.17.1 #2531

theScrabi opened this issue Aug 17, 2019 · 10 comments

Comments

@theScrabi
Copy link
Member

New

  • Thai localization

Improved

Fixed


Build version 0.17.1 RC1:

@tusch001
Copy link

Minor thing - just a suggestion:
First time video download on Android 6.0.1 when no download directory is set and SAF is not activated in settings yet:
The internal file explorer starts with the top folder (/) which could be a problem for new users who don't know about where android stores files.
I would suggest to open the file explorer with /sdcard or the downloads folder initially. Maybe activate SAF as default?

Just FYI: The internal file explorer only shows /sdcard but /storage/emulated doesn't show the subfolder to pick the internal sd (/storage/emulated/0). Don't know where the difference is to other apps on my phone - they don't have this problem. For users it doesn't matter - I can pick /sdcard.

My first impression is very positive: The video lists are shown very fast compared to 17.0-RC2.

@shadypt
Copy link

shadypt commented Aug 18, 2019

Starting from the v0.16.0 (I think) I started getting this error. To reproduce it go to settings -> video and audio, just scroll down and the app crashes. This is still present on the latest version.
Already reported several times via user report.
Thanks for the awesome app.

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Language: PT
  • Service: none
  • Version: 0.17.0
  • OS: Linux Android 8.1.0 - 27
    going on settings, audio and video, and scrolling all the way down, the app crashes
Crash log

java.util.FormatFlagsConversionMismatchException: Conversion = s, Flags =  
	at java.util.Formatter$FormatSpecifier.failMismatch(Formatter.java:4398)
	at java.util.Formatter$FormatSpecifier.checkBadFlags(Formatter.java:3091)
	at java.util.Formatter$FormatSpecifier.checkGeneral(Formatter.java:3049)
	at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2816)
	at java.util.Formatter$FormatSpecifierParser.<init>(Formatter.java:2624)
	at java.util.Formatter.parse(Formatter.java:2557)
	at java.util.Formatter.format(Formatter.java:2504)
	at java.util.Formatter.format(Formatter.java:2458)
	at java.lang.String.format(String.java:2770)
	at android.support.v7.preference.ListPreference.getSummary(ListPreference.java:178)
	at android.support.v7.preference.Preference.onBindViewHolder(Preference.java:584)
	at android.support.v7.preference.PreferenceGroupAdapter.onBindViewHolder(PreferenceGroupAdapter.java:381)
	at android.support.v7.preference.PreferenceGroupAdapter.onBindViewHolder(PreferenceGroupAdapter.java:45)
	at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:6781)
	at android.support.v7.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:6823)
	at android.support.v7.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:5752)
	at android.support.v7.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6019)
	at android.support.v7.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:286)
	at android.support.v7.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:343)
	at android.support.v7.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:359)
	at android.support.v7.widget.GapWorker.prefetch(GapWorker.java:366)
	at android.support.v7.widget.GapWorker.run(GapWorker.java:397)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6647)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)


Edit:

Still present on v0.17.1 RC1

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Language: PT
  • Service: none
  • Version: 0.17.1
  • OS: Linux Android 8.1.0 - 27
Crash log

java.util.FormatFlagsConversionMismatchException: Conversion = s, Flags =  
	at java.util.Formatter$FormatSpecifier.failMismatch(Formatter.java:4398)
	at java.util.Formatter$FormatSpecifier.checkBadFlags(Formatter.java:3091)
	at java.util.Formatter$FormatSpecifier.checkGeneral(Formatter.java:3049)
	at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2816)
	at java.util.Formatter$FormatSpecifierParser.<init>(Formatter.java:2624)
	at java.util.Formatter.parse(Formatter.java:2557)
	at java.util.Formatter.format(Formatter.java:2504)
	at java.util.Formatter.format(Formatter.java:2458)
	at java.lang.String.format(String.java:2770)
	at android.support.v7.preference.ListPreference.getSummary(ListPreference.java:178)
	at android.support.v7.preference.Preference.onBindViewHolder(Preference.java:584)
	at android.support.v7.preference.PreferenceGroupAdapter.onBindViewHolder(PreferenceGroupAdapter.java:381)
	at android.support.v7.preference.PreferenceGroupAdapter.onBindViewHolder(PreferenceGroupAdapter.java:45)
	at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:6781)
	at android.support.v7.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:6823)
	at android.support.v7.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:5752)
	at android.support.v7.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6019)
	at android.support.v7.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:286)
	at android.support.v7.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:343)
	at android.support.v7.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:359)
	at android.support.v7.widget.GapWorker.prefetch(GapWorker.java:366)
	at android.support.v7.widget.GapWorker.run(GapWorker.java:397)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6647)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)


@theScrabi
Copy link
Member Author

I cant reproduce that error.

@shadypt
Copy link

shadypt commented Aug 18, 2019

@theScrabi I can reproduce on another phone, a moto one vision. Here is the log

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Language: GB
  • Service: none
  • Version: 0.16.2
  • OS: Linux motorola/kane_reteu/kane_sprout:9/PSA29.137-17/6875e:user/release-keys 9 - 28
Crash log

java.util.FormatFlagsConversionMismatchException: Conversion = s, Flags =  
	at java.util.Formatter$FormatSpecifier.failMismatch(Formatter.java:4398)
	at java.util.Formatter$FormatSpecifier.checkBadFlags(Formatter.java:3091)
	at java.util.Formatter$FormatSpecifier.checkGeneral(Formatter.java:3049)
	at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2816)
	at java.util.Formatter$FormatSpecifierParser.<init>(Formatter.java:2624)
	at java.util.Formatter.parse(Formatter.java:2557)
	at java.util.Formatter.format(Formatter.java:2504)
	at java.util.Formatter.format(Formatter.java:2458)
	at java.lang.String.format(String.java:2842)
	at android.support.v7.preference.ListPreference.getSummary(ListPreference.java:178)
	at android.support.v7.preference.Preference.onBindViewHolder(Preference.java:584)
	at android.support.v7.preference.PreferenceGroupAdapter.onBindViewHolder(PreferenceGroupAdapter.java:381)
	at android.support.v7.preference.PreferenceGroupAdapter.onBindViewHolder(PreferenceGroupAdapter.java:45)
	at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:6781)
	at android.support.v7.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:6823)
	at android.support.v7.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:5752)
	at android.support.v7.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6019)
	at android.support.v7.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:286)
	at android.support.v7.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:343)
	at android.support.v7.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:359)
	at android.support.v7.widget.GapWorker.prefetch(GapWorker.java:366)
	at android.support.v7.widget.GapWorker.run(GapWorker.java:397)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:215)
	at android.app.ActivityThread.main(ActivityThread.java:6929)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:870)


@TobiGr
Copy link
Contributor

TobiGr commented Aug 18, 2019

@shadypt should be fixed with 96e1122

@shadypt
Copy link

shadypt commented Aug 18, 2019

@TobiGr Thanks, I will close the issue when fixed

@theScrabi
Copy link
Member Author

@TobiGr what do you think? Stable enough to be released?

@Stypox
Copy link
Member

Stypox commented Aug 19, 2019

  1. Open a standalone issue, this is not a bug introduced by 0.17.1
  2. please add filters to search functionality #110
    @unknowndelicateboy

@TobiGr
Copy link
Contributor

TobiGr commented Aug 19, 2019

@theScrabi yes

@BartFarley
Copy link

Still no "Start playing here" menu item in playlist nor channel pages.
I have installed v0.17.1 RC1.
Back to 0.16.2.
I use this feature quite a bit, and feel lost without it. €8•×
Also, if I'm posting these comments in the wrong place, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants